fix complex renderers #2392
fix complex renderers #2392
Conversation
…derer, use vuetify widgets for integer and number inputs
✅ Deploy Preview for jsonforms-examples ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@sdirix please review - this fixes oneOf renderer where it could clear out the whole data - check for example - oneOf - Preselection for Primitives (Issue 1273 ) example and try to switch between diferent oneOf when they are populated -once the dialog is clicked to apply the selectio the data will not be an object the other changes are some stuff that I'm looking to do and are part of the excercise - be able to have a generic editor for jsonschema - e.g. the schema to be the jsonschema meta model and then to be able to create a new jsonschema with that - other are other stuff that I'm working on fixing but are not yet ready - like having a MixedControl which can handle mixed types by asking you to select the type of the element before showing you the actual control to work with the data when creating a new data and if the data is present then automatically selecting the correct type. One thing that I'm having an issue is with the jsonforms core resolveSchema method which when it can't find the property it will return undefined and in the case of dynamic schema you do not really have a structure
and we try to find a property in that schema then the resolveSchema does not give me the schema that I have provided. Locally I'm doing some hacks which I do not really like for example attaching a Symbol keys to the schema that points to a function that can be then invoke by the resolveSchema in that particular case but that looks too hacky. If you have any suggestions please let me know. Also are you interested in such renderer - MixedRenderer or maybe we can call it UnionRenderer - anyway let me know if such one could go to the jsonform vuetify render repo - otherwise I won't spent much time to even prepare such PR |
| const input = useVuetifyControl(useJsonFormsControl(props), adaptValue); | ||
| // preserve the value as it was typed by the user - for example when the user type very long number if we rely on the control.data to return back the actual data then the string could appear with exponent form and etc. | ||
| // otherwise while typing the string in the input can suddenly change | ||
| const inputValue = ref((input.control.value.data as string) || ''); |
There was a problem hiding this comment.
Good idea with the simplications
| @@ -141,7 +142,7 @@ export const useVuetifyControl = < | |||
| }, | |||
| I extends { | |||
| control: ComputedRef<T>; | |||
| } & DispatchPropsOfControl, | |||
| } & (DispatchPropsOfControl | DispatchPropsOfMultiEnumControl), | |||
There was a problem hiding this comment.
Seems weird to add this type here. What is the rationale?
There was a problem hiding this comment.
so that we can use that useVuetifyControl with the EnumArrayRenderer instead of creating very similar method just for that renderer
There was a problem hiding this comment.
Hmm I see. The core issue is that we do not expose handleChange to these controls although I would have expected it. See for example the React renderers in which we not only do the specialized addIterm etc. but also expose the usual handleChange.
I'm fine with this for this PR but we should rework in the future I think
|
@sdirix all fixed and those that needed clarification please find those in the corresponding sections. |
update demo app, fix oneOf, allow passing slots to the dispatcher renderer, use vuetify widgets for integer and number inputs