Remove MaximumQoS property from CONNECT packet #240
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uded in MQTTv5.0 specification. Closes eclipse#161
|
I'll cancel this request and check the cause of error after all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #161
According to MQTTv5 spec, Maximum QoS property should not be included in CONNECT packet, but it may be included only in CONNACK packet.
Actually, I included that property in CONNECT and sent it to Mosquitto MQTT server, the connection was refused.
So, I also think we should remove Maximum QoS property from CONNECT packet in this library.
If you like this, I hope you can review this request.
Best Regards,
note:
I couldn't pass the test by 'make test' command each in this branch and also master with the following message. It seems to not be related to the change of this branch.