Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConnectProperties in cp_connect.go has a MaximumQOS field that is not part of the MQTT 5 specification #161

Closed
vishnureddy17 opened this issue Aug 15, 2023 · 2 comments · Fixed by #243
Closed

ConnectProperties in cp_connect.go has a MaximumQOS field that is not part of the MQTT 5 specification #161

vishnureddy17 opened this issue Aug 15, 2023 · 2 comments · Fixed by #243
Milestone
Version 1.0.0

Comments

@vishnureddy17
Copy link
Contributor

The MQTT 5 spec doesn't include a MaximumQOS field in CONNECT properties, but it is included as a field.

paho.golang/paho/cp_connect.go

Line 29 in 21b4033

MaximumQOS *byte

@MattBrittan
Copy link
Contributor

This ends up as property 36 "Maximum QoS" but that is only valid on CONNACK packets so this looks like a bug.

@MattBrittan
Copy link
Contributor

This also needs to be fixed in properties.go -

PropMaximumQOS: {CONNECT: {}, CONNACK: {}},

should be:

PropMaximumQOS: {CONNACK: {}},

@MattBrittan MattBrittan added this to the Version 1.0.0 milestone Feb 12, 2024
tomatod added a commit to tomatod/paho.golang that referenced this issue Feb 16, 2024
@tomatod
Remove MaximumQoS property from CONNECT packet, because it's not incl…
e3fc793 
…uded in MQTTv5.0 specification.

Closes eclipse#161
@tomatod tomatod mentioned this issue Feb 16, 2024
Closed
tomatod added a commit to tomatod/paho.golang that referenced this issue Feb 18, 2024
@tomatod
Remove MaximumQoS property from CONNECT packet, because it's not incl…
f618513 
…uded in MQTTv5.0 specification.

Closes eclipse#161
@tomatod tomatod mentioned this issue Feb 18, 2024
Merged
MattBrittan added a commit that referenced this issue Feb 26, 2024
@MattBrittan
Merge pull request #243 from tomatod/fix/remove-maximum-packet-size-f…
79a760b 
…rom-connect

Remove MaximumQoS property from CONNECT packet (it's only valid in the CONNACK packet)

Closes #161
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 1.0.0
2 participants
@vishnureddy17 @MattBrittan