Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README about build tools #9545

Merged
merged 7 commits into from Apr 5, 2023
Merged

Update README about build tools #9545

merged 7 commits into from Apr 5, 2023

Conversation

joakime
Copy link
Contributor

@joakime joakime commented Mar 27, 2023

No description provided.

@joakime
Update README about build tools
8bf1cc9 
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
@joakime joakime added the Build label Mar 27, 2023
@joakime joakime added this to the 10.0.x milestone Mar 27, 2023
@joakime joakime requested review from olamy and gregw March 27, 2023 18:15
@joakime joakime self-assigned this Mar 27, 2023
gregw
gregw previously approved these changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@gregw gregw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

olamy
olamy previously approved these changes Mar 27, 2023
View reviewed changes
Copy link
Member

@olamy olamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Maybe we should talk about Docker as well which is need to run some integration tests?

olamy
olamy reviewed Mar 27, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@olamy
Add Docker as tool needed for third party testing
00f3ae7 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy olamy dismissed stale reviews from gregw and themself via 00f3ae7 March 28, 2023 01:51
olamy
olamy reviewed Mar 28, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@olamy
fast build and jdk to use
cf37c6b 
Signed-off-by: Olivier Lamy <olamy@apache.org>
olamy
olamy previously approved these changes Mar 28, 2023
View reviewed changes
@joakime
Improved README
8273699 
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
sbordet
sbordet requested changes Mar 28, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@joakime
Even more build details in README
62cd4b2 
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
@joakime
Cleanup runner locations/branches
4fea53b 
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
sbordet
sbordet previously requested changes Mar 29, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
gregw
gregw requested changes Mar 30, 2023
View reviewed changes
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
gregw
gregw previously approved these changes Apr 4, 2023
View reviewed changes
@joakime joakime requested review from gregw, sbordet and olamy April 4, 2023 17:05
@joakime
Split jetty-runner rows
3638d0d 
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
@joakime joakime merged commit 642ce81 into jetty-10.0.x Apr 5, 2023
4 checks passed
@joakime joakime deleted the fix/10.0.x/updated-readme branch April 5, 2023 13:59
@olamy olamy mentioned this pull request Apr 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregw gregw gregw approved these changes

@sbordet sbordet Awaiting requested review from sbordet

@olamy olamy Awaiting requested review from olamy

Assignees

@joakime joakime

Labels
Build
Projects
None yet
Milestone
10.0.x
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@joakime @olamy @gregw @sbordet