Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insufficient documentation on required build tools #9536

Closed
gregw opened this issue Mar 25, 2023 · 5 comments
Closed

Insufficient documentation on required build tools #9536

gregw opened this issue Mar 25, 2023 · 5 comments
Assignees
Labels
Bug For general bugs on Jetty side

Comments

@gregw
Copy link
Contributor

gregw commented Mar 25, 2023

Jetty version(s)
10

OS type/version
linux

Description

Doing a full build from the command line results in the following error:

[INFO] asciidoctor: DEBUG: Finding 'dot' in attributes
[INFO] asciidoctor: DEBUG: Finding 'dot' in environment
java.io.IOException: Cannot run program "/opt/local/bin/dot": error=2, No such file or directory
        at java.base/java.lang.ProcessBuilder.start(ProcessBuilder.java:1143)
        at java.base/java.lang.ProcessBuilder.start(ProcessBuilder.java:1073)
        at java.base/java.lang.Runtime.exec(Runtime.java:594)
        at net.sourceforge.plantuml.cucadiagram.dot.ProcessRunner$MainThread.startThreads(ProcessRunner.java:159)
        at net.sourceforge.plantuml.cucadiagram.dot.ProcessRunner$MainThread.runJob(ProcessRunner.java:119)
        at net.sourceforge.plantuml.api.TimeoutExecutor$MyThread.run(TimeoutExecutor.java:76)
Caused by: java.io.IOException: error=2, No such file or directory
        at java.base/java.lang.ProcessImpl.forkAndExec(Native Method)
        at java.base/java.lang.ProcessImpl.<init>(ProcessImpl.java:314)
        at java.base/java.lang.ProcessImpl.start(ProcessImpl.java:244)
        at java.base/java.lang.ProcessBuilder.start(ProcessBuilder.java:1110)
        ... 5 more

I believe there is some optional third party documentation system that I need to install to resolve this, but nothing is documented in README.md

How to reproduce?

Do a full build

@gregw gregw added the Bug For general bugs on Jetty side label Mar 25, 2023
@gregw
Copy link
Contributor Author

gregw commented Mar 25, 2023

@sbordet @joakime @olamy Not sure who is best to document the documentation build system. Can one of you claim this issue and add a few lines in the README.md about what is needed.

@joakime
Copy link
Contributor

joakime commented Mar 25, 2023

I'll work on the README for jetty-10.0.x (onwards)

Meanwhile ...
dot is a binary from the graphviz toolkit.

It is used in the jetty-documentation portion of the build.
I thought we setup the dot tooling to be optional? (have to look into this)

@olamy
Copy link
Member

olamy commented Mar 26, 2023

yes It should be optional but generate warning/info/debug (noise?) only in the build output.
if this breaks the build it's definitely a bug

@gregw
Copy link
Contributor Author

gregw commented Mar 26, 2023

Yeah it is optional. Not breaking the build. Just adding noise whilst I'm looking at other build exceptions.

Also i forgot it was graphviz - thanks

@olamy
Copy link
Member

olamy commented Apr 17, 2023

fixed with #9545

@olamy olamy closed this as completed Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For general bugs on Jetty side
Projects
None yet
Development

No branches or pull requests

4 participants