Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provider fixes #88

Merged
merged 7 commits into from
Apr 26, 2023
Merged

Provider fixes #88

merged 7 commits into from
Apr 26, 2023

Conversation

mnlipp
Copy link
Contributor

@mnlipp mnlipp commented Apr 25, 2023

Fixes the explicitly specified OSGi headers as explained for angus activation here.

Copy link
Member

@lukasj lukasj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drop the first commit from this PR so it applies cleanly

@mnlipp
Copy link
Contributor Author

mnlipp commented Apr 26, 2023

drop the first commit from this PR so it applies cleanly

I cannot provide a PR against master (at least not a tested one) because master currently doesn't build (maven package fails). So this is actually a diff against 2.0.1.

@mnlipp
Copy link
Contributor Author

mnlipp commented Apr 26, 2023

Oh, and wait a second, I'm just trying a test without the "redundant" "statements".

@mnlipp
Copy link
Contributor Author

mnlipp commented Apr 26, 2023

Works. I've tested it with the angus-activation (as of eclipse-ee4j/angus-activation#37), jakarta.activation-api:2.1.1 and jakarta.mail-api:2.1.1. No more hk2 service loader needed!

Sorry about this not being mergeable. mvn package works with master today (no idea why it didn't yesterday) and so I rebased the branch on master. But for some reason maven changes the version in pom.xml when building. (I'll never understand maven and luckily I don't have to.)

@lukasj
Copy link
Member

lukasj commented Apr 26, 2023

You should be able to rebase now to get rid of the first commit, I believe the problem you had is fixed by #89 (workaround would be to use mvn -Poss-release -Dgpg.skip=true ...).

One more change to do is to put a note into changes.txt and we're done here

@lukasj lukasj self-requested a review April 26, 2023 12:22
@lukasj lukasj merged commit 56c0f84 into eclipse-ee4j:master Apr 26, 2023
3 checks passed
@lukasj
Copy link
Member

lukasj commented Apr 26, 2023

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants