Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: switch default java version to 17 #159

Merged
merged 1 commit into from
May 23, 2023
Merged

build: switch default java version to 17 #159

merged 1 commit into from
May 23, 2023
+2 −12

Conversation

ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented May 23, 2023

What this PR changes/adds

Change default java version to 17.

Why it does that

Briefly state why the change was necessary.

Further notes

  • cleanup build file a little

Linked Issue(s)

Closes #158

Checklist

  • added appropriate tests?
  • performed checkstyle check locally?
  • added/updated copyright headers?
  • documented public classes/methods?
  • added/updated relevant documentation?
  • assigned appropriate label? (exclude from changelog with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and Etiquette for pull requests for details)

Sorry, something went wrong.

@ndr-brt
build: switch default java version to 17
Loading
Loading status checks…
7ae3699
@ndr-brt ndr-brt added enhancement New feature or request build labels May 23, 2023
paullatzelsperger
paullatzelsperger approved these changes May 23, 2023
View reviewed changes
Copy link
Member

@paullatzelsperger paullatzelsperger left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤟

wolf4ood
wolf4ood approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@wolf4ood wolf4ood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@github-actions
Copy link

Test Results

38 tests  ±0   38 ✔️ ±0   21s ⏱️ -8s
12 suites ±0     0 💤 ±0 
12 files   ±0     0 ❌ ±0 

Results for commit 7ae3699. ± Comparison against base commit 9aee914.

@ndr-brt ndr-brt merged commit fa4aebd into main May 23, 2023
@ndr-brt ndr-brt deleted the 158-java-17 branch May 23, 2023 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolf4ood wolf4ood

@paullatzelsperger paullatzelsperger

@ronjaquensel ronjaquensel

Assignees
No one assigned
Labels
build enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch default java version to 17
3 participants
@ndr-brt @wolf4ood @paullatzelsperger