Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve modularity by introducing lib modules for cross depedencies #4046

Merged
merged 4 commits into from
Mar 26, 2024

Conversation

jimmarino
Copy link
Contributor

This PR is ongoing work to remove dependency tangles and improve modularity between different components. It introduces lib modules for shared implementations.

Linked Issue(s)

Related to #4028

@jimmarino jimmarino added the refactoring Cleaning up code and dependencies label Mar 26, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 74.11%. Comparing base (7f20ba5) to head (693a5b6).
Report is 167 commits behind head on main.

Files Patch % Lines
...onnector/ControlPlaneDefaultServicesExtension.java 0.00% 2 Missing ⚠️
...in/java/org/eclipse/edc/jsonld/TitaniumJsonLd.java 87.50% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4046      +/-   ##
==========================================
+ Coverage   71.74%   74.11%   +2.36%     
==========================================
  Files         919      986      +67     
  Lines       18457    20006    +1549     
  Branches     1037     1118      +81     
==========================================
+ Hits        13242    14827    +1585     
+ Misses       4756     4699      -57     
- Partials      459      480      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jimmarino jimmarino merged commit 83611ff into eclipse-edc:main Mar 26, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Cleaning up code and dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants