feat: introduces properties provider for DataFlowStartMessage #4044
+142
−64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...pi/src/main/java/org/eclipse/edc/connector/transfer/spi/flow/DataFlowPropertiesProvider.java
Fixed
Show fixed
Hide fixed
...pi/src/main/java/org/eclipse/edc/connector/transfer/spi/flow/DataFlowPropertiesProvider.java
Fixed
Show fixed
Hide fixed
wolf4ood
force-pushed
the
feat/4043_dps_custom_properties_extensions
branch
from
9441a66 to
6169d80
Compare
wolf4ood
force-pushed
the
feat/4043_dps_custom_properties_extensions
branch
from
6169d80 to
b6e6b4b
Compare
| @ExtensionPoint | ||
| public interface DataFlowPropertiesProvider { | ||
|
|
||
| StatusResult<Map<String, String>> propertiesFor(TransferProcess transferProcess, Policy policy); |
Check notice
Code scanning / CodeQL
Useless parameter Note
| @ExtensionPoint | ||
| public interface DataFlowPropertiesProvider { | ||
|
|
||
| StatusResult<Map<String, String>> propertiesFor(TransferProcess transferProcess, Policy policy); |
Check notice
Code scanning / CodeQL
Useless parameter Note
paullatzelsperger
approved these changes
Mar 26, 2024
ndr-brt
reviewed
Mar 26, 2024
| @@ -350,4 +315,63 @@ private TransferProcess.Builder transferProcessBuilder() { | |||
| .counterPartyAddress("test.connector.address") | |||
| .dataDestination(DataAddress.Builder.newInstance().type("test").build()); | |||
| } | |||
|
|
|||
| @Nested | |||
| class Suspend { | |||
There was a problem hiding this comment.
I was late for review, but why put tests under private methods? Doesn't look correct
There was a problem hiding this comment.
which tests are private?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Allows adding additional/custom properties when sending the
DataFlowStartMessagewith the DPS protocolA default provider is created, which returns an empty map
Why it does that
extensibility
Further notes
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Linked Issue(s)
Closes #4043