feat: store claims on additionalProperties #4000
Conversation
paullatzelsperger
force-pushed
the
feat/move_claims_to_additional_props
branch
from
8cb8d9f to
2884205
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| * @return success if access to the resource is granted, a failure otherwise. | ||
| */ | ||
| Result<Void> checkAccess(ClaimToken claimToken, DataAddress address, Map<String, Object> requestData); | ||
| Result<Void> checkAccess(ClaimToken claimToken, DataAddress address, Map<String, Object> requestData, Map<String, Object> additionalData); |
Check notice
Code scanning / CodeQL
Useless parameter Note
| * @return success if access to the resource is granted, a failure otherwise. | ||
| */ | ||
| Result<Void> checkAccess(ClaimToken claimToken, DataAddress address, Map<String, Object> requestData); | ||
| Result<Void> checkAccess(ClaimToken claimToken, DataAddress address, Map<String, Object> requestData, Map<String, Object> additionalData); |
Check notice
Code scanning / CodeQL
Useless parameter Note
| * @return success if access to the resource is granted, a failure otherwise. | ||
| */ | ||
| Result<Void> checkAccess(ClaimToken claimToken, DataAddress address, Map<String, Object> requestData); | ||
| Result<Void> checkAccess(ClaimToken claimToken, DataAddress address, Map<String, Object> requestData, Map<String, Object> additionalData); |
Check notice
Code scanning / CodeQL
Useless parameter Note
| * @return success if access to the resource is granted, a failure otherwise. | ||
| */ | ||
| Result<Void> checkAccess(ClaimToken claimToken, DataAddress address, Map<String, Object> requestData); | ||
| Result<Void> checkAccess(ClaimToken claimToken, DataAddress address, Map<String, Object> requestData, Map<String, Object> additionalData); |
Check notice
Code scanning / CodeQL
Useless parameter Note
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #4000 +/- ##
==========================================
+ Coverage 71.74% 73.40% +1.65%
==========================================
Files 919 975 +56
Lines 18457 19662 +1205
Branches 1037 1105 +68
==========================================
+ Hits 13242 14432 +1190
- Misses 4756 4759 +3
- Partials 459 471 +12 ☔ View full report in Codecov by Sentry. |
What this PR changes/adds
some additional claims, that were previously stored as claims on the EDR's
access_tokenwere moved to theadditionalPropertiesmap on theAccessTokenData.Specifically:
participantId, processId, assetId, agreementId, transferTypeWhy it does that
Having those on the access token is not necessary. The access token should be as slim as possible.
Further notes
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Linked Issue(s)
Closes # <-- insert Issue number if one exists
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.