feat: register default PublicEndpointGenerator fct #3991
Merged
+30
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullatzelsperger
added
enhancement
paullatzelsperger
requested review from
ndr-brt,
bscholtes1A and
jimmarino
as code owners
paullatzelsperger
force-pushed
the
feat/add_default_endpointgenerator
branch
from
c5a8a64 to
439907f
Compare
wolf4ood
approved these changes
Mar 11, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...pi-v2/src/main/java/org/eclipse/edc/connector/dataplane/api/DataPlanePublicApiExtension.java
Fixed
Show fixed
Hide fixed
paullatzelsperger
force-pushed
the
feat/add_default_endpointgenerator
branch
from
439907f to
e6ea851
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
This PR adds an optional config property
edc.dataplane.api.public.baseurlthat configures the base URL (including host, port) of theDataPlanePublicApiController.If that config value is not provided, a fallback
http://<HOST>:<PORT>/<PATH>is constructed dynamically, and is determined by the following config properties:HOST: determined by the injectedHostname, defaulting tolocalhostPORT: determined byweb.http.public.port, defaulting to8185PATH: determined byweb.http.public.path, defaulting to/api/v1/publicWhy it does that
Every dataplane should be able to represent itself as
EndpointFurther notes
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Linked Issue(s)
Closes # <-- insert Issue number if one exists
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.