refactor: make resource manifest generator handle TransferProcess #3979
Conversation
ndr-brt
added
refactoring
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| */ | ||
|
|
||
| boolean canGenerate(DataRequest dataRequest, DataAddress assetAddress, Policy policy); | ||
| boolean canGenerate(TransferProcess transferProcess, DataAddress assetAddress, Policy policy); |
Check notice
Code scanning / CodeQL
Useless parameter Note
| */ | ||
|
|
||
| boolean canGenerate(DataRequest dataRequest, DataAddress assetAddress, Policy policy); | ||
| boolean canGenerate(TransferProcess transferProcess, DataAddress assetAddress, Policy policy); |
Check notice
Code scanning / CodeQL
Useless parameter Note
| */ | ||
| @Nullable | ||
| ResourceDefinition generate(DataRequest dataRequest, DataAddress assetAddress, Policy policy); | ||
| ResourceDefinition generate(TransferProcess transferProcess, DataAddress assetAddress, Policy policy); |
Check notice
Code scanning / CodeQL
Useless parameter Note
| */ | ||
| @Nullable | ||
| ResourceDefinition generate(DataRequest dataRequest, DataAddress assetAddress, Policy policy); | ||
| ResourceDefinition generate(TransferProcess transferProcess, DataAddress assetAddress, Policy policy); |
Check notice
Code scanning / CodeQL
Useless parameter Note
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3979 +/- ##
==========================================
+ Coverage 71.74% 73.39% +1.64%
==========================================
Files 919 961 +42
Lines 18457 19392 +935
Branches 1037 1093 +56
==========================================
+ Hits 13242 14232 +990
+ Misses 4756 4696 -60
- Partials 459 464 +5 ☔ View full report in Codecov by Sentry. |
ndr-brt
changed the title
ndr-brt
force-pushed
the
3732-purge-data-request-part-one
branch
from
46d485b to
621aaff
Compare
…tead of DataRequest
ndr-brt
force-pushed
the
3732-purge-data-request-part-one
branch
from
621aaff to
1e561b2
Compare
What this PR changes/adds
First refactoring step to inline
DataRequest, makeResourceManifestGeneratorand relative consumer/provider interfaces to acceptTransferProcessinstead ofDataRequest** Breaking change ** for those who implemented a custom
ConsumerResourceDefinitionGeneratoror aProviderResourceDefinitionGenerator, pretty straightforward to adaptWhy it does that
refactoring
Further notes
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Linked Issue(s)
Part of #3732
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.