Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: EDR (data address) and metadata storage/cache #3978

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

wolf4ood
Copy link
Contributor

@wolf4ood wolf4ood commented Mar 7, 2024

What this PR changes/adds

Introduces an EDR (dataaddress) cache and associated metadata storage:

  • introduced edr-store-spi module
  • introduced edr-store-core module with default implementations

In the spi three extensible interface are introduced:

  • EndpointDataReferenceStore: the main entry point for storing and retrieving EDR and metadata associated
  • EndpointDataReferenceCache subcomponent for caching EDR (DataAddress) in a secured environment
  • EndpointDataReferenceEntryIndex subcomponent for storing EDR metadata (assetId, agreementId, ..etc)

The default implementation of EndpointDataReferenceStore uses the two subcomponents for dealing with EDR and metadata.

A default implementation of EndpointDataReferenceCache backed by the Vault is provider as well as an in memory one for the metadata storage EndpointDataReferenceEntryIndex

Why it does that

data plane signaling, user experience

Linked Issue(s)

Closes #3973

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@wolf4ood wolf4ood force-pushed the feat/3973_edr_cache branch from 21a4f48 to 1de52b1 Compare March 7, 2024 17:40
@wolf4ood wolf4ood self-assigned this Mar 7, 2024
@wolf4ood wolf4ood added the enhancement New feature or request label Mar 7, 2024
@wolf4ood wolf4ood force-pushed the feat/3973_edr_cache branch 2 times, most recently from 40f591e to 77a1e12 Compare March 7, 2024 18:41
@wolf4ood wolf4ood changed the title feat: EDR (dataaddress) and metadata storage/cache feat: EDR (data address) and metadata storage/cache Mar 8, 2024
@wolf4ood wolf4ood force-pushed the feat/3973_edr_cache branch 4 times, most recently from a0a51ba to bf02501 Compare March 8, 2024 10:10
@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 87.03704% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 73.49%. Comparing base (7f20ba5) to head (8ba277b).
Report is 129 commits behind head on main.

Files Patch % Lines
.../edr/defaults/VaultEndpointDataReferenceCache.java 76.00% 5 Missing and 1 partial ⚠️
...n/java/org/eclipse/edc/spi/result/StoreResult.java 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3978      +/-   ##
==========================================
+ Coverage   71.74%   73.49%   +1.74%     
==========================================
  Files         919      968      +49     
  Lines       18457    19506    +1049     
  Branches     1037     1097      +60     
==========================================
+ Hits        13242    14335    +1093     
+ Misses       4756     4705      -51     
- Partials      459      466       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wolf4ood wolf4ood marked this pull request as ready for review March 8, 2024 10:30
Copy link
Member

@paullatzelsperger paullatzelsperger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@wolf4ood wolf4ood force-pushed the feat/3973_edr_cache branch from bf02501 to 8ba277b Compare March 8, 2024 11:49
@wolf4ood wolf4ood merged commit 95d71be into eclipse-edc:main Mar 8, 2024
17 checks passed
@wolf4ood wolf4ood deleted the feat/3973_edr_cache branch March 8, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DPS: In Memory EDR cache
3 participants