feat: DPS API controller #3955
Merged
feat: DPS API controller #3955
+672
−149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullatzelsperger
requested review from
ndr-brt,
bscholtes1A and
jimmarino
as code owners
paullatzelsperger
added
enhancement
paullatzelsperger
force-pushed
the
feat/dps_api_controller
branch
2 times, most recently
from
81bc493 to
5520ce7
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3955 +/- ##
==========================================
+ Coverage 71.74% 73.33% +1.58%
==========================================
Files 919 958 +39
Lines 18457 19254 +797
Branches 1037 1089 +52
==========================================
+ Hits 13242 14119 +877
+ Misses 4756 4674 -82
- Partials 459 461 +2 ☔ View full report in Codecov by Sentry. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+111
to
+113
| var msg = typeTransformerRegistry.transform(suspendMessage, DataFlowSuspendMessage.class) | ||
| .onFailure(f -> monitor.warning("Error transforming %s: %s".formatted(DataFlowSuspendMessage.class, f.getFailureDetail()))) | ||
| .orElseThrow(InvalidRequestException::new); |
Check notice
Code scanning / CodeQL
Unread local variable Note
paullatzelsperger
force-pushed
the
feat/dps_api_controller
branch
4 times, most recently
from
47909da to
2ac797d
Compare
paullatzelsperger
force-pushed
the
feat/dps_api_controller
branch
from
2ac797d to
b68a320
Compare
|
Merging as this PR is a duplicate of an already approved one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Implements the DataPlaneSignalingApi
Why it does that
Briefly state why the change was necessary.
Further notes
DataFlowsfor which no source was found, is now possible. Previously that would have resulted in a failure.DataFlowsnow takes an optionalreasonargument that gets persisted in the data flow entity.Note this PR is an exact duplicate of #3951. I ran into some weird git/caching issue, so I had to recreate the PR.
Linked Issue(s)
Closes #3911
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.