chore: refactor DataFlowRequest into DataFlowStartMessage #3913
+276
−226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @Override | ||
| public Builder self() { | ||
| return this; | ||
| } | ||
|
|
||
| public DataPlaneManagerImpl build() { |
Check notice
Code scanning / CodeQL
Missing Override annotation Note
| * @return the service to be used to serve the request, selected among the input {@code transferServices}, or {@code null} if the stream is empty or no service should be used. | ||
| */ | ||
| @Nullable | ||
| TransferService chooseTransferService(DataFlowStartMessage request, Stream<TransferService> transferServices); |
Check notice
Code scanning / CodeQL
Useless parameter Note
wolf4ood
force-pushed
the
feat/3908_data_flow_request_refactor
branch
3 times, most recently
from
6399595 to
f44ec71
Compare
wolf4ood
force-pushed
the
feat/3908_data_flow_request_refactor
branch
from
f44ec71 to
c5f1864
Compare
wolf4ood
requested review from
bscholtes1A,
jimmarino and
paullatzelsperger
as code owners
jimmarino
approved these changes
Feb 23, 2024
paullatzelsperger
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
renames
DataFlowRequesttoDataFlowStartMessageand additional fields addedWhy it does that
refactoring for data plane signaling
Linked Issue(s)
Closes #3908
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.