feat: support contains operator for postgresql #3793
Merged
+722
−162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndr-brt
requested review from
bscholtes1A,
jimmarino and
paullatzelsperger
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
extensions/common/sql/sql-core/src/main/java/org/eclipse/edc/sql/translation/SqlOperator.java
Fixed
Show fixed
Hide fixed
extensions/common/sql/sql-core/src/main/java/org/eclipse/edc/sql/translation/SqlOperator.java
Fixed
Show fixed
Hide fixed
paullatzelsperger
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Adds support for
containsoperator in SQL as it was done for in-memory store.Adds flexibility, defining a
SqlOperatorTranslatorinterface that permits to specify how the operator is defined in the specific SQL implementation.Why it does that
stores feature consistence
Further notes
JsonFieldTranslatoris postgresql specific but it's located in thesql-core, same for thePostgresOperatorTranslator, maybe we should extract apostgresqlextension that takes care of registering common postgresql-related services, "refactoring never ends" :)validateOperatorfrom theSqlQueryStatementconstructor, because now that's implicit in theSqlOperatorTranslatorcomponent: if the operator gets translated is valid, otherwise it's not.Linked Issue(s)
Closes #3736
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.