refactor: extract the translation logic from the TranslationMapping class #3780
+234
−78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullatzelsperger
approved these changes
Jan 17, 2024
...sions/common/sql/sql-core/src/main/java/org/eclipse/edc/sql/translation/FieldTranslator.java
Outdated
Show resolved
Hide resolved
...ns/common/sql/sql-core/src/main/java/org/eclipse/edc/sql/translation/SortFieldConverter.java
Show resolved
Hide resolved
ndr-brt
force-pushed
the
3736-sql-contains-operator
branch
from
39cdb24 to
62971e9
Compare
ndr-brt
force-pushed
the
3736-sql-contains-operator
branch
from
ff546df to
f450688
Compare
jimmarino
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
second refactoring toward the solution of #3736
in this PR the "translation" logic that was implemented in the
TranslationMappinghierarchy has been extracted to a new interfaceFieldTranslatorand its hierarchy, whileTranslationMappingremains a simple tree data structure that can provide theFieldTranslatorto the caller (we could find a better name for it, suggestions welcome)Why it does that
now that we have the
FieldTranslatorwe can add a method there that can return aWhereClausedirectly, giving the possibility to translate the whole criteria following the specific SQL implementationFurther notes
Linked Issue(s)
Part of #3736
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.