refactor: introduce CriterionToWhereClauseConverter
#3737
Merged
+323
−282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
extensions/common/sql/sql-core/src/main/java/org/eclipse/edc/sql/translation/WhereClause.java
Fixed
Show fixed
Hide fixed
extensions/common/sql/sql-core/src/main/java/org/eclipse/edc/sql/translation/WhereClause.java
Fixed
Show fixed
Hide fixed
ndr-brt
force-pushed
the
3736-introduce-criterion-to-where-clause-converter
branch
from
44e3628 to
96d59b9
Compare
paullatzelsperger
approved these changes
Dec 27, 2023
.../sql-core/src/main/java/org/eclipse/edc/sql/translation/CriterionToWhereClauseConverter.java
Show resolved
Hide resolved
|
This pull request is stale because it has been open for 7 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Provide a
CriterionToWhereClauseConverter, that, likeCriterionToPredicateConverterconverts aCriterioninto an object that can be use to query a data set, in this case a SQL one.This is a part of the refactoring explained in #3736, because otherwise the PR would have been too big.
The next step would be to make the
TranslationMappingable to build the fullWhereClauseobject by itself.Why it does that
refactoring
Further notes
Linked Issue(s)
Part of #3736
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.