-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Introduce transfer type #3727
Conversation
5c32702
to
fb8b409
Compare
fb8b409
to
ff0d1a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is transferType
added on DataRequest
? This value object has no particular use in the current implementation so I would add transferType
directly on the TransferProcess
@ndr-brt no particular reason, all the DSP/ protocol related informations are stored in the |
yes, the merging process proceeds really slowly 😁 I think we should not add new stuff on the |
Cool make sense :) |
3bb626d
to
994af8e
Compare
What this PR changes/adds
Introduce the transfer type concept as outlined in the DR #3637.
Adds the transfer type field in:
TransferRequest
DataRequest
TransferRequestMessage
DataFlowRequest
and their transformers when necessary.
The
TransferRequest#dataTestination
(DataAddress) is still mandatory, even in the case where thetransferType
could be enough for the transfer, like in thePULL
s scenarios (Backward compatibiliy).The EDC
DataFlowController
s :ConsumerPullTransferDataFlowController
ProviderPushTransferDataFlowController
have been slightly modified to be backward compatible in case they receive the
transferType
field.Why it does that
Decouple the type of transfer from the
DataAddress#type
of the destination in a transfer requestLinked Issue(s)
Closes #3724