Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ios: Increase size of drop down button #138

Merged
merged 2 commits into from
Dec 1, 2023

Conversation

shakyShane
Copy link
Collaborator

@shakyShane shakyShane commented Dec 1, 2023

https://app.asana.com/0/0/1206073695355523/f

Description:

Steps to test this PR:

  1. use this branch of the dashboard 12-01-ios_Increase_size_of_drop_down_button
  2. check the height on device matches the screenshot seen in the diff

@shakyShane
Copy link
Collaborator Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

Copy link
Member

@federicocappelli federicocappelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

- Values can be `true` or `false`
- Example: [http://localhost:3220/html/popup.html?platform=browser&contentBlockingException=true](http://localhost:3220/html/popup.html?platform=browser&contentBlockingException=true)
- `locale` - You can set this to any supported language, such as `locale=pl`
When you run `npm run preview`, it opens `iframe.html` which contains iframes for all the individual platforms.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this part of this PR on purpose?

@shakyShane shakyShane merged commit 38336a5 into main Dec 1, 2023
6 checks passed
@shakyShane shakyShane deleted the 12-01-ios_Increase_size_of_drop_down_button branch December 1, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants