Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ios breakage form #136

Merged
merged 11 commits into from
Nov 17, 2023
Merged

ios breakage form #136

merged 11 commits into from
Nov 17, 2023

Conversation

shakyShane
Copy link
Collaborator

@shakyShane shakyShane commented Nov 14, 2023

Reviewer: @federicocappelli

Description:

  • allows the dashboard's feedback form to be opened directly, by passing ?screen=breakageForm
    • when doing this, it does NOT allow navigation to the primary screen

Steps to test this PR:

  • please see the iOS PR

@shakyShane
Copy link
Collaborator Author

@shakyShane shakyShane changed the base branch from shane/port-toggle-2 to main November 15, 2023 18:39
@federicocappelli
Copy link
Member

LGTM, Tested in iOS and macOS, is all good except for a minor bug in iOS when in landscape.

@shakyShane shakyShane merged commit 59dedf0 into main Nov 17, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants