Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚡️ Target ES2020 in produced bundle #5787

Merged
merged 4 commits into from
Mar 6, 2025
Merged

⚡️ Target ES2020 in produced bundle #5787

merged 4 commits into from
Mar 6, 2025

Conversation

dubzzz
Copy link
Owner

@dubzzz dubzzz commented Mar 6, 2025

Description

The bundle of fast-check that we have been producing until now were targeting ES2017. As such any feature not compatible with this standard got transpiled to be compatible.

While allowing older versions of node to be able to run fast-check properly it created a performance cliff for others. With v4 and our target being moved to ES2020 we increased the target version to ES2020.

ChecklistDon't delete this checklist and make sure you do the following before opening the PR

  • The name of my PR follows gitmoji specification
  • My PR references one of several related issues (if any)
    • New features or breaking changes must come with an associated Issue or Discussion
    • My PR does not add any new dependency without an associated Issue or Discussion
  • My PR includes bumps details, please run pnpm run bump and flag the impacts properly
  • My PR adds relevant tests and they would have failed without my PR (when applicable)

Advanced

  • Category: ...
  • Impacts: ...

Sorry, something went wrong.

The bundle of fast-check that we have been producing until now were targeting ES2017. As such any feature not compatible with this standard got transpiled to be compatible.

While allowing older versions of node to be able to run fast-check properly it created a performance cliff for others. With v4 and our target being moved to ES2020 we increased the target version to ES2020.
Copy link

changeset-bot bot commented Mar 6, 2025

🦋 Changeset detected

Latest commit: 82e800e

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

dubzzz added 2 commits March 6, 2025 21:36
@dubzzz dubzzz changed the title ⚡️Target ES2020 in produced bundle ⚡️ Target ES2020 in produced bundle Mar 6, 2025
Copy link

pkg-pr-new bot commented Mar 6, 2025

Open in Stackblitz@fast-check/examples

@fast-check/ava

npm i https://pkg.pr.new/@fast-check/ava@5787

@fast-check/expect-type

npm i https://pkg.pr.new/@fast-check/expect-type@5787

fast-check

npm i https://pkg.pr.new/fast-check@5787

@fast-check/jest

npm i https://pkg.pr.new/@fast-check/jest@5787

@fast-check/packaged

npm i https://pkg.pr.new/@fast-check/packaged@5787

@fast-check/poisoning

npm i https://pkg.pr.new/@fast-check/poisoning@5787

@fast-check/vitest

npm i https://pkg.pr.new/@fast-check/vitest@5787

@fast-check/worker

npm i https://pkg.pr.new/@fast-check/worker@5787

commit: 82e800e

Copy link

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.73%. Comparing base (77549c4) to head (82e800e).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5787   +/-   ##
=======================================
  Coverage   94.73%   94.73%           
=======================================
  Files         212      212           
  Lines       10057    10057           
  Branches     2670     2670           
=======================================
  Hits         9527     9527           
  Misses        530      530           
Flag Coverage Δ
unit-tests 94.73% <ø> (ø)
unit-tests-18.x-Linux 94.73% <ø> (ø)
unit-tests-20.x-Linux 94.73% <ø> (ø)
unit-tests-22.x-Linux 94.73% <ø> (ø)
unit-tests-latest-Linux 94.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dubzzz dubzzz enabled auto-merge (squash) March 6, 2025 21:52
Copy link
Contributor

github-actions bot commented Mar 6, 2025

👋 A preview of the new documentation is available at: http://67ca1a08b007959edcf9beea--dubzzz-fast-check.netlify.app

@dubzzz dubzzz merged commit 9746b95 into main Mar 6, 2025
73 checks passed
@dubzzz dubzzz deleted the target-es2020 branch March 6, 2025 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant