-
-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚡️ Target ES2020 in produced bundle #5787
Conversation
The bundle of fast-check that we have been producing until now were targeting ES2017. As such any feature not compatible with this standard got transpiled to be compatible. While allowing older versions of node to be able to run fast-check properly it created a performance cliff for others. With v4 and our target being moved to ES2020 we increased the target version to ES2020.
🦋 Changeset detectedLatest commit: 82e800e The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Open in Stackblitz • @fast-check/examples @fast-check/ava
@fast-check/expect-type
fast-check
@fast-check/jest
@fast-check/packaged
@fast-check/poisoning
@fast-check/vitest
@fast-check/worker
commit: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5787 +/- ##
=======================================
Coverage 94.73% 94.73%
=======================================
Files 212 212
Lines 10057 10057
Branches 2670 2670
=======================================
Hits 9527 9527
Misses 530 530
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
👋 A preview of the new documentation is available at: http://67ca1a08b007959edcf9beea--dubzzz-fast-check.netlify.app |
Description
The bundle of fast-check that we have been producing until now were targeting ES2017. As such any feature not compatible with this standard got transpiled to be compatible.
While allowing older versions of node to be able to run fast-check properly it created a performance cliff for others. With v4 and our target being moved to ES2020 we increased the target version to ES2020.
Checklist — Don't delete this checklist and make sure you do the following before opening the PR
pnpm run bump
and flag the impacts properlyAdvanced