Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚡️ Mark all arbitraries as side-effect free #5786

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

dubzzz
Copy link
Owner

@dubzzz dubzzz commented Mar 6, 2025

Description

Fixes #5560

ChecklistDon't delete this checklist and make sure you do the following before opening the PR

  • The name of my PR follows gitmoji specification
  • My PR references one of several related issues (if any)
    • New features or breaking changes must come with an associated Issue or Discussion
    • My PR does not add any new dependency without an associated Issue or Discussion
  • My PR includes bumps details, please run pnpm run bump and flag the impacts properly
  • My PR adds relevant tests and they would have failed without my PR (when applicable)

Advanced

  • Category: ...
  • Impacts: Lighter bundles when fast-check pulled by bundles

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Fixes #5560
Copy link

changeset-bot bot commented Mar 6, 2025

⚠️ No Changeset found

Latest commit: 21538da

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented Mar 6, 2025

Open in Stackblitz@fast-check/examples

@fast-check/ava

npm i https://pkg.pr.new/@fast-check/ava@5786

@fast-check/expect-type

npm i https://pkg.pr.new/@fast-check/expect-type@5786

fast-check

npm i https://pkg.pr.new/fast-check@5786

@fast-check/jest

npm i https://pkg.pr.new/@fast-check/jest@5786

@fast-check/packaged

npm i https://pkg.pr.new/@fast-check/packaged@5786

@fast-check/poisoning

npm i https://pkg.pr.new/@fast-check/poisoning@5786

@fast-check/vitest

npm i https://pkg.pr.new/@fast-check/vitest@5786

@fast-check/worker

npm i https://pkg.pr.new/@fast-check/worker@5786

commit: 21538da

Copy link
Contributor

github-actions bot commented Mar 6, 2025

👋 A preview of the new documentation is available at: http://67ca119132a614c2be2cfbfb--dubzzz-fast-check.netlify.app

Copy link

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.73%. Comparing base (9723dcf) to head (21538da).
Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5786   +/-   ##
=======================================
  Coverage   94.73%   94.73%           
=======================================
  Files         212      212           
  Lines       10057    10057           
  Branches     2670     2670           
=======================================
  Hits         9527     9527           
  Misses        530      530           
Flag Coverage Δ
unit-tests 94.73% <ø> (ø)
unit-tests-18.x-Linux 94.73% <ø> (ø)
unit-tests-20.x-Linux 94.73% <ø> (ø)
unit-tests-22.x-Linux 94.73% <ø> (ø)
unit-tests-latest-Linux 94.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dubzzz dubzzz merged commit 76caa6a into main Mar 6, 2025
76 of 107 checks passed
@dubzzz dubzzz deleted the mark-all-arbitraries-side-free branch March 6, 2025 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lighter bundles with no-side-effect
1 participant