-
-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🏷️ Simplify types for fc.record
#5783
Conversation
🦋 Changeset detectedLatest commit: 35ccedc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
fc.record
fc.record
Thanks a lot for the contribution, running the CI to assess everything pass before merging |
@ahrjarrett The command |
Ah, it looks like the build is failing because the number of type parameters changed. I didn't run the test suite locally before pushing -- I'll do that this time. |
Think it should be good to go now. I had to fix a few linting errors, which makes me wonder if my version of eslint is being pulled from a cache on my machine. Let me know if you'd like me to revert this commit |
packages/fast-check/src/arbitrary/_internals/ConstantArbitrary.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally it would be great not to put the linting related changes in the same PR. No problem to send them in another PR but ideally not in this one.
Open in Stackblitz • @fast-check/examples @fast-check/ava
@fast-check/expect-type
fast-check
@fast-check/jest
@fast-check/packaged
@fast-check/poisoning
@fast-check/vitest
@fast-check/worker
commit: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5783 +/- ##
=======================================
Coverage 94.73% 94.73%
=======================================
Files 212 212
Lines 10057 10057
Branches 2670 2670
=======================================
Hits 9527 9527
Misses 530 530
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Worth the revert and then you'll have to format again as formatting seems to be broken on the head |
This reverts commit 0474aed.
@dubzzz I reverted and re-formatted, should be ready to go now |
**Description** This PR fixes the linting error that was backed out of #5783 - [x] The name of my PR follows [gitmoji](https://gitmoji.dev/) specification - [x] My PR references one of several related issues (if any) - [x] New features or breaking changes must come with an associated Issue or Discussion - [x] My PR does not add any new dependency without an associated Issue or Discussion - [x] My PR includes bumps details, please run `pnpm run bump` and flag the impacts properly - [x] My PR adds relevant tests and they would have failed without my PR (when applicable) --------- Co-authored-by: Nicolas DUBIEN <github@dubien.org>
Closes #5434
Description
This PR implements what was discussed in #5434.
This is my first contribution, so let me know if I missed any steps, if you'd like me to add any tests, etc.
Checklist — Don't delete this checklist and make sure you do the following before opening the PR
pnpm run bump
and flag the impacts properlyAdvanced