Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏷️ Simplify types for fc.record #5783

Merged
merged 14 commits into from
Mar 8, 2025

Conversation

ahrjarrett
Copy link
Contributor

Closes #5434

Description

This PR implements what was discussed in #5434.

This is my first contribution, so let me know if I missed any steps, if you'd like me to add any tests, etc.

ChecklistDon't delete this checklist and make sure you do the following before opening the PR

  • The name of my PR follows gitmoji specification
  • My PR references one of several related issues (if any)
    • New features or breaking changes must come with an associated Issue or Discussion
    • My PR does not add any new dependency without an associated Issue or Discussion
  • My PR includes bumps details, please run pnpm run bump and flag the impacts properly
  • My PR adds relevant tests and they would have failed without my PR (when applicable)

Advanced

  • Category: 🏷️
  • Impacts: N/A

Sorry, something went wrong.

@ahrjarrett ahrjarrett requested a review from dubzzz as a code owner March 6, 2025 07:36
Copy link

changeset-bot bot commented Mar 6, 2025

🦋 Changeset detected

Latest commit: 35ccedc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
fast-check Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dubzzz dubzzz changed the title 🏷️: simplify types for fc.record 🏷️ Simplify types for fc.record Mar 6, 2025
dubzzz
dubzzz previously approved these changes Mar 6, 2025
@dubzzz
Copy link
Owner

dubzzz commented Mar 6, 2025

Thanks a lot for the contribution, running the CI to assess everything pass before merging

@dubzzz
Copy link
Owner

dubzzz commented Mar 6, 2025

@ahrjarrett The command pnpm format would need to be executed

dubzzz
dubzzz previously approved these changes Mar 6, 2025
@ahrjarrett
Copy link
Contributor Author

Ah, it looks like the build is failing because the number of type parameters changed. I didn't run the test suite locally before pushing -- I'll do that this time.

@ahrjarrett ahrjarrett requested a review from dubzzz March 6, 2025 23:38
@ahrjarrett
Copy link
Contributor Author

Think it should be good to go now. I had to fix a few linting errors, which makes me wonder if my version of eslint is being pulled from a cache on my machine.

Let me know if you'd like me to revert this commit

Copy link
Owner

@dubzzz dubzzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally it would be great not to put the linting related changes in the same PR. No problem to send them in another PR but ideally not in this one.

Copy link

pkg-pr-new bot commented Mar 7, 2025

Open in Stackblitz@fast-check/examples

@fast-check/ava

npm i https://pkg.pr.new/@fast-check/ava@5783

@fast-check/expect-type

npm i https://pkg.pr.new/@fast-check/expect-type@5783

fast-check

npm i https://pkg.pr.new/fast-check@5783

@fast-check/jest

npm i https://pkg.pr.new/@fast-check/jest@5783

@fast-check/packaged

npm i https://pkg.pr.new/@fast-check/packaged@5783

@fast-check/poisoning

npm i https://pkg.pr.new/@fast-check/poisoning@5783

@fast-check/vitest

npm i https://pkg.pr.new/@fast-check/vitest@5783

@fast-check/worker

npm i https://pkg.pr.new/@fast-check/worker@5783

commit: 35ccedc

Copy link

codecov bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.73%. Comparing base (eeff420) to head (35ccedc).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5783   +/-   ##
=======================================
  Coverage   94.73%   94.73%           
=======================================
  Files         212      212           
  Lines       10057    10057           
  Branches     2670     2670           
=======================================
  Hits         9527     9527           
  Misses        530      530           
Flag Coverage Δ
unit-tests 94.73% <ø> (ø)
unit-tests-18.x-Linux 94.73% <ø> (?)
unit-tests-20.x-Linux 94.73% <ø> (?)
unit-tests-22.x-Linux 94.73% <ø> (ø)
unit-tests-latest-Linux 94.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dubzzz
Copy link
Owner

dubzzz commented Mar 7, 2025

Worth the revert and then you'll have to format again as formatting seems to be broken on the head

@ahrjarrett
Copy link
Contributor Author

@dubzzz I reverted and re-formatted, should be ready to go now

@dubzzz dubzzz merged commit 2853c0d into dubzzz:main Mar 8, 2025
73 of 74 checks passed
dubzzz added a commit that referenced this pull request Mar 8, 2025
**Description**

This PR fixes the linting error that was backed out of #5783

- [x] The name of my PR follows [gitmoji](https://gitmoji.dev/)
specification
- [x] My PR references one of several related issues (if any)
- [x] New features or breaking changes must come with an associated
Issue or Discussion
- [x] My PR does not add any new dependency without an associated Issue
or Discussion
- [x] My PR includes bumps details, please run `pnpm run bump` and flag
the impacts properly
- [x] My PR adds relevant tests and they would have failed without my PR
(when applicable)

---------

Co-authored-by: Nicolas DUBIEN <github@dubien.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature request / idea: simplify types for fc.record
2 participants