Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✅ Fix test in double.spec #5756

Merged
merged 1 commit into from
Feb 28, 2025
Merged

✅ Fix test in double.spec #5756

merged 1 commit into from
Feb 28, 2025

Conversation

gruhn
Copy link
Contributor

@gruhn gruhn commented Feb 27, 2025

Description

ChecklistDon't delete this checklist and make sure you do the following before opening the PR

  • The name of my PR follows gitmoji specification
  • My PR references one of several related issues (if any)
    • New features or breaking changes must come with an associated Issue or Discussion
    • My PR does not add any new dependency without an associated Issue or Discussion
  • My PR includes bumps details, please run pnpm run bump and flag the impacts properly
  • My PR adds relevant tests and they would have failed without my PR (when applicable)

Advanced

  • Category: ✅ Add or update tests
  • Impacts: no user impact to be expected

See: #5494

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
@gruhn gruhn requested a review from dubzzz as a code owner February 27, 2025 16:47
Copy link

changeset-bot bot commented Feb 27, 2025

🦋 Changeset detected

Latest commit: 3764718

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
fast-check
@fast-check/ava Patch
@fast-check/jest Patch
@fast-check/vitest Patch
@fast-check/worker Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Feb 27, 2025

Open in Stackblitz@fast-check/examples

@fast-check/ava

npm i https://pkg.pr.new/@fast-check/ava@5756

@fast-check/expect-type

npm i https://pkg.pr.new/@fast-check/expect-type@5756

@fast-check/jest

npm i https://pkg.pr.new/@fast-check/jest@5756

fast-check

npm i https://pkg.pr.new/fast-check@5756

@fast-check/packaged

npm i https://pkg.pr.new/@fast-check/packaged@5756

@fast-check/poisoning

npm i https://pkg.pr.new/@fast-check/poisoning@5756

@fast-check/vitest

npm i https://pkg.pr.new/@fast-check/vitest@5756

@fast-check/worker

npm i https://pkg.pr.new/@fast-check/worker@5756

commit: 3764718

Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.49%. Comparing base (b89d401) to head (3764718).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5756   +/-   ##
=======================================
  Coverage   94.49%   94.49%           
=======================================
  Files         212      212           
  Lines        9623     9623           
  Branches     2670     2671    +1     
=======================================
  Hits         9093     9093           
  Misses        530      530           
Flag Coverage Δ
unit-tests 94.49% <ø> (ø)
unit-tests-18.x-Linux 94.49% <ø> (ø)
unit-tests-20.x-Linux 94.49% <ø> (ø)
unit-tests-22.x-Linux 94.49% <ø> (ø)
unit-tests-latest-Linux 94.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dubzzz dubzzz changed the title ✅ Fix test in double.spec ✅ Fix test in double.spec Feb 28, 2025
@dubzzz dubzzz merged commit 8ed2d2e into dubzzz:main Feb 28, 2025
72 of 73 checks passed
@dubzzz
Copy link
Owner

dubzzz commented Feb 28, 2025

Thanks a lot for the fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants