💥 Drop deprecated ascii*
#5636
Merged
💥 Drop deprecated ascii*
#5636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Description**
<!-- Please provide a short description and potentially linked issues
justifying the need for this PR -->
The arbitraries `ascii` and `asciiString` have been marked for
deprecation since version 3.22.0.
They are now being fully dropped.
If you still want to rely on something behaving this way we recommend
you to use the following constructs:
```js
// for asciiString
string({ unit: 'binary-ascii' })
// for ascii
string({ unit: 'binary-ascii', minLength: 1, maxLength: 1 })
```
<!-- * Your PR is fixing a bug or regression? Check for existing issues
related to this bug and link them -->
<!-- * Your PR is adding a new feature? Make sure there is a related
issue or discussion attached to it -->
<!-- You can provide any additional context to help into understanding
what's this PR is attempting to solve: reproduction of a bug, code
snippets... -->
**Checklist** — _Don't delete this checklist and make sure you do the
following before opening the PR_
- [x] The name of my PR follows [gitmoji](https://gitmoji.dev/)
specification
- [x] My PR references one of several related issues (if any)
- [x] New features or breaking changes must come with an associated
Issue or Discussion
- [x] My PR does not add any new dependency without an associated Issue
or Discussion
- [x] My PR includes bumps details, please run `yarn bump` and flag the
impacts properly
- [x] My PR adds relevant tests and they would have failed without my PR
(when applicable)
<!-- More about contributing at
https://github.com/dubzzz/fast-check/blob/main/CONTRIBUTING.md -->
**Advanced**
<!-- How to fill the advanced section is detailed below! -->
- [x] Category: 💥 Breaking change
- [x] Impacts: Dropped arbitraries
<!-- [Category] Please use one of the categories below, it will help us
into better understanding the urgency of the PR -->
<!-- * ✨ Introduce new features -->
<!-- * 📝 Add or update documentation -->
<!-- * ✅ Add or update tests -->
<!-- * 🐛 Fix a bug -->
<!-- * 🏷️ Add or update types -->
<!-- * ⚡️ Improve performance -->
<!-- * _Other(s):_ ... -->
<!-- [Impacts] Please provide a comma separated list of the potential
impacts that might be introduced by this change -->
<!-- * Generated values: Can your change impact any of the existing
generators in terms of generated values, if so which ones? when? -->
<!-- * Shrink values: Can your change impact any of the existing
generators in terms of shrink values, if so which ones? when? -->
<!-- * Performance: Can it require some typings changes on user side?
Please give more details -->
<!-- * Typings: Is there a potential performance impact? In which cases?
-->
🦋 Changeset detectedLatest commit: abc9077 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Open in Stackblitz • @fast-check/examples @fast-check/ava
fast-check
@fast-check/expect-type
@fast-check/jest
@fast-check/packaged
@fast-check/poisoning
@fast-check/vitest
@fast-check/worker
commit: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5636 +/- ##
==========================================
- Coverage 94.82% 94.81% -0.02%
==========================================
Files 232 230 -2
Lines 10009 9989 -20
Branches 2804 2803 -1
==========================================
- Hits 9491 9471 -20
Misses 518 518
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
👋 A preview of the new documentation is available at: http://67915102de02c000bcb66b41--dubzzz-fast-check.netlify.app |
|
👋 A preview of the new documentation is available at: http://6791530f19cfd70a58ac1507--dubzzz-fast-check.netlify.app |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The arbitraries
asciiandasciiStringhave been marked for deprecation since version 3.22.0.They are now being fully dropped.
If you still want to rely on something behaving this way we recommend you to use the following constructs:
Checklist — Don't delete this checklist and make sure you do the following before opening the PR
yarn bumpand flag the impacts properlyAdvanced