-
-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚡️ Speed-up race-condition schedulers #5615
Conversation
**💥 Breaking change** This PR makes schedulers faster. By being faster it means that code that was previously passing may start to fail. Additionally it may predates `waitAll` and makes it not working in some cases that relied on this lucky slow scheduler. The new scheduler implementation will try to be as fast as possible and skip as few as possible frames. In this change scheduler takes action in places where it used not to because it was waiting for no reasons. Recreating #3891
🦋 Changeset detectedLatest commit: 5c30bae The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Open in Stackblitz • @fast-check/examples @fast-check/ava
@fast-check/expect-type
fast-check
@fast-check/jest
@fast-check/packaged
@fast-check/poisoning
@fast-check/vitest
@fast-check/worker
commit: |
👋 A preview of the new documentation is available at: http://6786cbefb66d86e183b34af4--dubzzz-fast-check.netlify.app |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5615 +/- ##
=======================================
Coverage 94.80% 94.80%
=======================================
Files 235 235
Lines 10030 10030
Branches 2820 2826 +6
=======================================
Hits 9509 9509
Misses 521 521
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Description
This PR makes schedulers faster. By being faster it means that code that was previously passing may start to fail. Additionally it may predates
waitAll
and makes it not working in some cases that relied on this lucky slow scheduler.The new scheduler implementation will try to be as fast as possible and skip as few as possible frames. In this change scheduler takes action in places where it used not to because it was waiting for no reasons.
Recreating #3891
Checklist — Don't delete this checklist and make sure you do the following before opening the PR
yarn bump
and flag the impacts properlyAdvanced
💥 Breaking change