Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚡️ Speed-up race-condition schedulers #5615

Merged
merged 3 commits into from
Jan 14, 2025
Merged

⚡️ Speed-up race-condition schedulers #5615

merged 3 commits into from
Jan 14, 2025

Conversation

dubzzz
Copy link
Owner

@dubzzz dubzzz commented Jan 14, 2025

Description

This PR makes schedulers faster. By being faster it means that code that was previously passing may start to fail. Additionally it may predates waitAll and makes it not working in some cases that relied on this lucky slow scheduler.

The new scheduler implementation will try to be as fast as possible and skip as few as possible frames. In this change scheduler takes action in places where it used not to because it was waiting for no reasons.

Recreating #3891

ChecklistDon't delete this checklist and make sure you do the following before opening the PR

  • The name of my PR follows gitmoji specification
  • My PR references one of several related issues (if any)
    • New features or breaking changes must come with an associated Issue or Discussion
    • My PR does not add any new dependency without an associated Issue or Discussion
  • My PR includes bumps details, please run yarn bump and flag the impacts properly
  • My PR adds relevant tests and they would have failed without my PR (when applicable)

Advanced

💥 Breaking change

Sorry, something went wrong.

**💥 Breaking change**

This PR makes schedulers faster. By being faster it means that code that was previously passing may start to fail. Additionally it may predates `waitAll` and makes it not working in some cases that relied on this lucky slow scheduler.

The new scheduler implementation will try to be as fast as possible and skip as few as possible frames. In this change scheduler takes action in places where it used not to because it was waiting for no reasons.

Recreating #3891
Copy link

changeset-bot bot commented Jan 14, 2025

🦋 Changeset detected

Latest commit: 5c30bae

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
fast-check Major
@fast-check/ava Patch
@fast-check/jest Patch
@fast-check/vitest Patch
@fast-check/worker Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dubzzz dubzzz enabled auto-merge (squash) January 14, 2025 20:32
Copy link

pkg-pr-new bot commented Jan 14, 2025

Open in Stackblitz@fast-check/examples

@fast-check/ava

npm i https://pkg.pr.new/@fast-check/ava@5615

@fast-check/expect-type

npm i https://pkg.pr.new/@fast-check/expect-type@5615

fast-check

npm i https://pkg.pr.new/fast-check@5615

@fast-check/jest

npm i https://pkg.pr.new/@fast-check/jest@5615

@fast-check/packaged

npm i https://pkg.pr.new/@fast-check/packaged@5615

@fast-check/poisoning

npm i https://pkg.pr.new/@fast-check/poisoning@5615

@fast-check/vitest

npm i https://pkg.pr.new/@fast-check/vitest@5615

@fast-check/worker

npm i https://pkg.pr.new/@fast-check/worker@5615

commit: 5c30bae

Copy link
Contributor

👋 A preview of the new documentation is available at: http://6786cbefb66d86e183b34af4--dubzzz-fast-check.netlify.app

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.80%. Comparing base (440e67f) to head (5c30bae).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5615   +/-   ##
=======================================
  Coverage   94.80%   94.80%           
=======================================
  Files         235      235           
  Lines       10030    10030           
  Branches     2820     2826    +6     
=======================================
  Hits         9509     9509           
  Misses        521      521           
Flag Coverage Δ
unit-tests 94.80% <100.00%> (ø)
unit-tests-18.x-Linux 94.80% <100.00%> (ø)
unit-tests-20.x-Linux 94.80% <100.00%> (ø)
unit-tests-22.x-Linux 94.80% <100.00%> (?)
unit-tests-latest-Linux 94.80% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dubzzz dubzzz merged commit 64d2887 into main Jan 14, 2025
58 checks passed
@dubzzz dubzzz deleted the pr-4718 branch January 14, 2025 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant