🐛 Better rejection handling in scheduleSequence
#5604
Merged
+21
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**👀 Potentially risky** (risk: low) The PR #4714 started to rewrite part of the method to make it easier to evolve. In its original implementation each scheduled item was defining its own error handling on the side and a global error handing was responsible to capture any last crash. This new approach puts the local item-related error handling in the then-sequence and not forked from it. In theory, it should not break anything, but as it plays with Promises we can have unwantingly added some extra then step or dropped one. As such it should probably not be released outside of a minor or major version.
🦋 Changeset detectedLatest commit: 23ac2bf The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dubzzz
changed the title
scheduleSequence (#4715)scheduleSequence
|
Open in Stackblitz • @fast-check/examples @fast-check/ava
@fast-check/expect-type
fast-check
@fast-check/jest
@fast-check/packaged
@fast-check/poisoning
@fast-check/vitest
@fast-check/worker
commit: |
|
👋 A preview of the new documentation is available at: http://67861965a23bf6cf8e7c43b3--dubzzz-fast-check.netlify.app |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5604 +/- ##
=======================================
Coverage 94.77% 94.77%
=======================================
Files 235 235
Lines 10036 10037 +1
Branches 2827 2827
=======================================
+ Hits 9512 9513 +1
Misses 524 524
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR #5600 started to rewrite part of the method to make it easier to evolve. In its original implementation each scheduled item was defining its own error handling on the side and a global error handing was responsible to capture any last crash.
This new approach puts the local item-related error handling in the then-sequence and not forked from it.
Checklist — Don't delete this checklist and make sure you do the following before opening the PR
yarn bumpand flag the impacts properlyAdvanced
👀 Potentially risky (risk: low): In theory, it should not break anything, but as it plays with Promises we can have unwantingly added some extra then step or dropped one. As such it should probably not be released outside of a minor or major version.