Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💥 Include null-prototype by default in record #5597

Merged
merged 5 commits into from
Jan 14, 2025
Merged

💥 Include null-prototype by default in record #5597

merged 5 commits into from
Jan 14, 2025

Conversation

dubzzz
Copy link
Owner

@dubzzz dubzzz commented Jan 11, 2025

Description

By default, instances generated by record will possibly be prototype-less.

If you want to enforce the prototype (Object), you will have to pass an extra option to record: noNullPrototype: true. In the past (v3) the flag used to be defaulted to true, it will now be defaulted to false.

ChecklistDon't delete this checklist and make sure you do the following before opening the PR

  • The name of my PR follows gitmoji specification
  • My PR references one of several related issues (if any)
    • New features or breaking changes must come with an associated Issue or Discussion
    • My PR does not add any new dependency without an associated Issue or Discussion
  • My PR includes bumps details, please run yarn bump and flag the impacts properly
  • My PR adds relevant tests and they would have failed without my PR (when applicable)

Advanced

💥 Breaking change: Produced values may come with no prototype being set

Sorry, something went wrong.

**💥 Breaking change**

By default, instances generated by `record` will possibly be prototype-less.

If you want to enforce the prototype (Object), you will have to pass an extra option to `record`: `noNullPrototype: true`.
In the past (v3) the flag used to be defaulted to true, it will now be defaulted to false.
Copy link

changeset-bot bot commented Jan 11, 2025

🦋 Changeset detected

Latest commit: 8da9e7b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
fast-check Major
@fast-check/ava Patch
@fast-check/jest Patch
@fast-check/vitest Patch
@fast-check/worker Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Jan 11, 2025

Open in Stackblitz@fast-check/examples

@fast-check/ava

npm i https://pkg.pr.new/@fast-check/ava@5597

@fast-check/expect-type

npm i https://pkg.pr.new/@fast-check/expect-type@5597

fast-check

npm i https://pkg.pr.new/fast-check@5597

@fast-check/jest

npm i https://pkg.pr.new/@fast-check/jest@5597

@fast-check/packaged

npm i https://pkg.pr.new/@fast-check/packaged@5597

@fast-check/poisoning

npm i https://pkg.pr.new/@fast-check/poisoning@5597

@fast-check/vitest

npm i https://pkg.pr.new/@fast-check/vitest@5597

@fast-check/worker

npm i https://pkg.pr.new/@fast-check/worker@5597

commit: 8da9e7b

Copy link
Contributor

👋 A preview of the new documentation is available at: http://6782c2be3574760fd30c88b8--dubzzz-fast-check.netlify.app

Copy link
Contributor

👋 A preview of the new documentation is available at: http://6782c3d45534e70dcdbab708--dubzzz-fast-check.netlify.app

Copy link

codecov bot commented Jan 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.77%. Comparing base (c806d57) to head (8da9e7b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5597      +/-   ##
==========================================
- Coverage   94.77%   94.77%   -0.01%     
==========================================
  Files         235      235              
  Lines       10036    10035       -1     
  Branches     2826     2827       +1     
==========================================
- Hits         9512     9511       -1     
  Misses        524      524              
Flag Coverage Δ
unit-tests 94.77% <100.00%> (-0.01%) ⬇️
unit-tests-18.x-Linux 94.77% <100.00%> (-0.01%) ⬇️
unit-tests-20.x-Linux 94.72% <100.00%> (-0.06%) ⬇️
unit-tests-22.x-Linux 94.72% <100.00%> (-0.06%) ⬇️
unit-tests-latest-Linux 94.77% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dubzzz dubzzz changed the title 💥 Include null-prototype by default in record (#4488) 💥 Include null-prototype by default in record Jan 14, 2025
@dubzzz dubzzz enabled auto-merge (squash) January 14, 2025 07:20
Copy link
Contributor

👋 A preview of the new documentation is available at: http://678610e9afe7a2c7609343f4--dubzzz-fast-check.netlify.app

@dubzzz dubzzz merged commit 94a4a7f into main Jan 14, 2025
57 checks passed
@dubzzz dubzzz deleted the pr-4488 branch January 14, 2025 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant