Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💥 Error with cause by default #5590

Merged
merged 9 commits into from
Jan 10, 2025
Merged

💥 Error with cause by default #5590

merged 9 commits into from
Jan 10, 2025

Conversation

dubzzz
Copy link
Owner

@dubzzz dubzzz commented Jan 10, 2025

Description

Until now, fast-check have been merging the content and stack of the original Error that caused the property to fail into its own Error. With the recent (2022) introduction of cause on Errors, this complex logic can be dropped in favor of the native cause mechanism.

This PR makes cause mode the default. Before this PR, toggling it was possible via errorWithCause: true on fc.assert.

Given not all test runners properly support causes attached to the Error, we offer a fallback for users willing to preserve the old behaviour. It can be toggled via includeErrorInReport: true on fc.assert.

Related to #4416.

ChecklistDon't delete this checklist and make sure you do the following before opening the PR

  • The name of my PR follows gitmoji specification
  • My PR references one of several related issues (if any)
    • New features or breaking changes must come with an associated Issue or Discussion
    • My PR does not add any new dependency without an associated Issue or Discussion
  • My PR includes bumps details, please run yarn bump and flag the impacts properly
  • My PR adds relevant tests and they would have failed without my PR (when applicable)

Advanced

💥 Breaking change: The display of errors being reported by fast-check will change. Many test runners do support that but some still don't support it so a flag will have to be pass for them to display the errors correctly.

Sorry, something went wrong.

**💥 Breaking change**

Until now, fast-check have been merging the content and stack of the original Error that caused the property to fail into its own Error. With the recent (2022) introduction of cause on Errors, this complex logic can be dropped in favor of the native cause mechanism.

This PR makes cause mode the default. Before this PR, toggling it was possible via `errorWithCause: true` on `fc.assert`.

Given not all test runners properly support causes attached to the Error, we offer a fallback for users willing to preserve the old behaviour. It can be toggled via `includeErrorInReport: true` on `fc.assert`.

Related to #4416.
Copy link

changeset-bot bot commented Jan 10, 2025

🦋 Changeset detected

Latest commit: b3be369

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
fast-check Major
@fast-check/ava Patch
@fast-check/jest Patch
@fast-check/vitest Patch
@fast-check/worker Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Jan 10, 2025

Open in Stackblitz@fast-check/examples

@fast-check/ava

npm i https://pkg.pr.new/@fast-check/ava@5590

@fast-check/expect-type

npm i https://pkg.pr.new/@fast-check/expect-type@5590

@fast-check/jest

npm i https://pkg.pr.new/@fast-check/jest@5590

fast-check

npm i https://pkg.pr.new/fast-check@5590

@fast-check/packaged

npm i https://pkg.pr.new/@fast-check/packaged@5590

@fast-check/poisoning

npm i https://pkg.pr.new/@fast-check/poisoning@5590

@fast-check/vitest

npm i https://pkg.pr.new/@fast-check/vitest@5590

@fast-check/worker

npm i https://pkg.pr.new/@fast-check/worker@5590

commit: b3be369

Copy link
Contributor

👋 A preview of the new documentation is available at: http://6780dc3bc9adf6629bbba664--dubzzz-fast-check.netlify.app

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.77%. Comparing base (d5108bb) to head (b3be369).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5590      +/-   ##
==========================================
+ Coverage   94.70%   94.77%   +0.06%     
==========================================
  Files         235      235              
  Lines       10036    10036              
  Branches     2821     2827       +6     
==========================================
+ Hits         9505     9512       +7     
+ Misses        531      524       -7     
Flag Coverage Δ
unit-tests 94.77% <100.00%> (+0.06%) ⬆️
unit-tests-18.x-Linux 94.77% <100.00%> (+0.06%) ⬆️
unit-tests-20.x-Linux 94.77% <100.00%> (+0.06%) ⬆️
unit-tests-22.x-Linux 94.77% <100.00%> (+0.06%) ⬆️
unit-tests-latest-Linux 94.77% <100.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

doc
@dubzzz dubzzz enabled auto-merge (squash) January 10, 2025 08:54
Copy link
Contributor

👋 A preview of the new documentation is available at: http://6780e1379d9bf278d5b3b806--dubzzz-fast-check.netlify.app

Copy link
Contributor

👋 A preview of the new documentation is available at: http://6781ad63c4a4228def287ea0--dubzzz-fast-check.netlify.app

@dubzzz dubzzz merged commit c806d57 into main Jan 10, 2025
57 checks passed
@dubzzz dubzzz deleted the pr-4489 branch January 10, 2025 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant