Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏷️ Better typings for constantFrom #5577

Merged
merged 6 commits into from
Jan 7, 2025
Merged

🏷️ Better typings for constantFrom #5577

merged 6 commits into from
Jan 7, 2025

Conversation

dubzzz
Copy link
Owner

@dubzzz dubzzz commented Jan 7, 2025

Description

As recommended by #4047, let's leverage const generics to make usage of constantFrom even simpler for TS users.

ChecklistDon't delete this checklist and make sure you do the following before opening the PR

  • The name of my PR follows gitmoji specification
  • My PR references one of several related issues (if any)
    • New features or breaking changes must come with an associated Issue or Discussion
    • My PR does not add any new dependency without an associated Issue or Discussion
  • My PR includes bumps details, please run yarn bump and flag the impacts properly
  • My PR adds relevant tests and they would have failed without my PR (when applicable)

Advanced

⚠️ Minor breaking change: Requires users to use a more recent version of TypeScript.

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
As recommended by #4047, let's leverage const generics to make usage of `constantFrom` even simpler for TS users.

Original PR being #4103.
Copy link

changeset-bot bot commented Jan 7, 2025

🦋 Changeset detected

Latest commit: d0d4227

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
fast-check Major
@fast-check/ava Patch
@fast-check/jest Patch
@fast-check/vitest Patch
@fast-check/worker Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

dubzzz added 5 commits January 7, 2025 19:42

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…r-4103
Copy link

pkg-pr-new bot commented Jan 7, 2025

Open in Stackblitz@fast-check/examples

@fast-check/ava

npm i https://pkg.pr.new/@fast-check/ava@5577

fast-check

npm i https://pkg.pr.new/fast-check@5577

@fast-check/expect-type

npm i https://pkg.pr.new/@fast-check/expect-type@5577

@fast-check/jest

npm i https://pkg.pr.new/@fast-check/jest@5577

@fast-check/poisoning

npm i https://pkg.pr.new/@fast-check/poisoning@5577

@fast-check/packaged

npm i https://pkg.pr.new/@fast-check/packaged@5577

@fast-check/vitest

npm i https://pkg.pr.new/@fast-check/vitest@5577

@fast-check/worker

npm i https://pkg.pr.new/@fast-check/worker@5577

commit: d0d4227

Copy link
Contributor

github-actions bot commented Jan 7, 2025

👋 A preview of the new documentation is available at: http://677d796cbcc0c811e4fee1b4--dubzzz-fast-check.netlify.app

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.91%. Comparing base (95e5453) to head (d0d4227).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5577   +/-   ##
=======================================
  Coverage   94.91%   94.91%           
=======================================
  Files         235      235           
  Lines       10048    10048           
  Branches     2840     2840           
=======================================
  Hits         9537     9537           
  Misses        511      511           
Flag Coverage Δ
unit-tests 94.91% <100.00%> (ø)
unit-tests-18.x-Linux 94.91% <100.00%> (ø)
unit-tests-20.x-Linux 94.91% <100.00%> (ø)
unit-tests-22.x-Linux 94.91% <100.00%> (ø)
unit-tests-latest-Linux 94.91% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dubzzz dubzzz merged commit 9edd896 into main Jan 7, 2025
73 checks passed
@dubzzz dubzzz deleted the pr-4103 branch January 7, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant