🐛 Make depth retrieval more resilient to poisoning #5515
Merged
+9
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Retrieving the depth is a shared operations that can be leveraged by various of our arbitraries. Its current implementation was possibly leading to poisoning crashes into some very specific circumstances. This PR drops a few remaing problematic cases. In theory, while backing ourselves against poisoning is important for us, it should not bring any visible difference to our users except into very corrupted and vulnerable code they could have wrote.
🦋 Changeset detectedLatest commit: 507593f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Open in Stackblitz • @fast-check/examples @fast-check/ava
@fast-check/expect-type
fast-check
@fast-check/jest
@fast-check/packaged
@fast-check/poisoning
@fast-check/vitest
@fast-check/worker
commit: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5515 +/- ##
=======================================
Coverage 94.91% 94.91%
=======================================
Files 235 235
Lines 10040 10041 +1
Branches 2838 2840 +2
=======================================
+ Hits 9529 9530 +1
Misses 511 511
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
👋 A preview of the new documentation is available at: http://675b6e0b6c1b9b1f6a12ebc2--dubzzz-fast-check.netlify.app |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Retrieving the depth is a shared operations that can be leveraged by various of our arbitraries. Its current implementation was possibly leading to poisoning crashes into some very specific circumstances. This PR drops a few remaing problematic cases.
In theory, while backing ourselves against poisoning is important for us, it should not bring any visible difference to our users except into very corrupted and vulnerable code they could have wrote.
Checklist — Don't delete this checklist and make sure you do the following before opening the PR
yarn bumpand flag the impacts properlyAdvanced