Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Make stringify a bit more resilient to poisoning #5468

Merged
merged 3 commits into from
Dec 10, 2024

Conversation

dubzzz
Copy link
Owner

@dubzzz dubzzz commented Dec 2, 2024

Description

While we may still miss lots of poisoning cases, we try to be closer to a fully poisoning free implementation for stringify. There are still problems and risks of poisoning in the implementation but we dropped some of them with this PR.

In theory it should make tests easier to troubleshoot in case the test failed because of a poisoning it introduced itself.

ChecklistDon't delete this checklist and make sure you do the following before opening the PR

  • The name of my PR follows gitmoji specification
  • My PR references one of several related issues (if any)
    • New features or breaking changes must come with an associated Issue or Discussion
    • My PR does not add any new dependency without an associated Issue or Discussion
  • My PR includes bumps details, please run yarn bump and flag the impacts properly
  • My PR adds relevant tests and they would have failed without my PR (when applicable)

Advanced

  • Category: 🐛 Fix a bug
  • Impacts: None expected, should be more resilient to poisoning

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
While we may still miss lots of poisoning cases, we try to be closer to a fully poisoning free implementation for `stringify`. There are still problems and risks of poisoning in the implementation but we dropped some of them with this PR.

In theory it should make tests easier to troubleshoot in case the test failed because of a poisoning it introduced itself.
Copy link

changeset-bot bot commented Dec 2, 2024

🦋 Changeset detected

Latest commit: 34cad17

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
fast-check Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Dec 9, 2024

Open in Stackblitz@fast-check/examples

@fast-check/ava

npm i https://pkg.pr.new/@fast-check/ava@5468

@fast-check/expect-type

npm i https://pkg.pr.new/@fast-check/expect-type@5468

fast-check

npm i https://pkg.pr.new/fast-check@5468

@fast-check/jest

npm i https://pkg.pr.new/@fast-check/jest@5468

@fast-check/packaged

npm i https://pkg.pr.new/@fast-check/packaged@5468

@fast-check/poisoning

npm i https://pkg.pr.new/@fast-check/poisoning@5468

@fast-check/vitest

npm i https://pkg.pr.new/@fast-check/vitest@5468

@fast-check/worker

npm i https://pkg.pr.new/@fast-check/worker@5468

commit: 34cad17

Copy link
Contributor

github-actions bot commented Dec 9, 2024

👋 A preview of the new documentation is available at: http://675775214fe336390d5d7fbc--dubzzz-fast-check.netlify.app

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.14%. Comparing base (2f0bb24) to head (34cad17).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5468   +/-   ##
=======================================
  Coverage   95.14%   95.14%           
=======================================
  Files         235      235           
  Lines       10522    10522           
  Branches     2839     2840    +1     
=======================================
  Hits        10011    10011           
  Misses        511      511           
Flag Coverage Δ
unit-tests 95.14% <100.00%> (ø)
unit-tests-18.x-Linux 95.09% <100.00%> (-0.05%) ⬇️
unit-tests-20.x-Linux 95.14% <100.00%> (ø)
unit-tests-22.x-Linux 95.14% <100.00%> (ø)
unit-tests-latest-Linux 95.14% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dubzzz dubzzz merged commit 163875b into main Dec 10, 2024
74 checks passed
@dubzzz dubzzz deleted the poisoning-free-stringify branch December 10, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant