Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✅ Safer rewrite of Poisoning E2E #4866

Merged
merged 4 commits into from
Apr 6, 2024
Merged

✅ Safer rewrite of Poisoning E2E #4866

merged 4 commits into from
Apr 6, 2024

Conversation

dubzzz
Copy link
Owner

@dubzzz dubzzz commented Apr 5, 2024

This new version drops the need for @fast-check/poisoning and only recreate what it drops itself. With the previous versions, it could have recreate things that were not created by itself.

Category:

  • ✨ Introduce new features
  • 📝 Add or update documentation
  • ✅ Add or update tests
  • 🐛 Fix a bug
  • 🏷️ Add or update types
  • ⚡️ Improve performance
  • Other(s): ...

Potential impacts:

  • Generated values
  • Shrink values
  • Performance
  • Typings
  • Other(s): ...

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
This new version drops the need for `@fast-check/poisoning` and only recreate what it drops itself. With the previous versions, it could have recreate things that were not created by itself.
Copy link

codesandbox-ci bot commented Apr 5, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit df29a65:

Sandbox Source
@fast-check/examples Configuration

@dubzzz dubzzz enabled auto-merge (squash) April 5, 2024 07:35
Copy link
Contributor

github-actions bot commented Apr 5, 2024

👋 A preview of the new documentation is available at: http://660faa329e3ab0617c41661f--dubzzz-fast-check.netlify.app

dubzzz added 3 commits April 6, 2024 15:08

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link
Contributor

github-actions bot commented Apr 6, 2024

👋 A preview of the new documentation is available at: http://661166b56670f5f7f9c726cf--dubzzz-fast-check.netlify.app

Copy link

codecov bot commented Apr 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.49%. Comparing base (1b2a01d) to head (df29a65).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4866   +/-   ##
=======================================
  Coverage   93.49%   93.49%           
=======================================
  Files         207      207           
  Lines        5015     5015           
  Branches     1314     1368   +54     
=======================================
  Hits         4689     4689           
  Misses        326      326           
Flag Coverage Δ
unit-tests 93.49% <ø> (ø)
unit-tests-18.x-Linux 93.49% <ø> (ø)
unit-tests-20.x-Linux 93.49% <ø> (ø)
unit-tests-latest-Linux 93.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dubzzz dubzzz merged commit 9711e54 into main Apr 6, 2024
52 checks passed
@dubzzz dubzzz deleted the rewrite-poisoning-test branch April 6, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant