✨ Stop repeating the error twice in reports #3638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While the change could have been considered as a bug fix, I prefer including it as a fresh new feature to avoid risks of breaking people relying on this bug. Fixes #3634
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 96ba665:
|
dubzzz
commented
Feb 21, 2023
packages/fast-check/test/e2e/__snapshots__/NoRegressionStack.spec.ts.snap
Outdated
Show resolved
Hide resolved
dubzzz
commented
Feb 22, 2023
packages/fast-check/test/e2e/__snapshots__/NoRegressionStack.spec.ts.snap
Outdated
Show resolved
Hide resolved
packages/fast-check/test/e2e/__snapshots__/NoRegressionStack.spec.ts.snap
Outdated
Show resolved
Hide resolved
packages/fast-check/test/e2e/__snapshots__/NoRegressionStack.spec.ts.snap
Outdated
Show resolved
Hide resolved
packages/fast-check/test/e2e/__snapshots__/NoRegressionStack.spec.ts.snap
Outdated
Show resolved
Hide resolved
…-check into do-not-repeat-stacks
Codecov Report
@@ Coverage Diff @@
## main #3638 +/- ##
==========================================
- Coverage 95.68% 95.65% -0.04%
==========================================
Files 201 201
Lines 5197 5206 +9
Branches 1105 1106 +1
==========================================
+ Hits 4973 4980 +7
- Misses 215 217 +2
Partials 9 9
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the change could have been considered as a bug fix, I prefer including it as a fresh new feature to avoid risks of breaking people relying on this bug.
I don't really consider it to be a behaviour change. It mostly changes a stringified version of the error which comes in addition to a raw version of it. So not worth a major.
Fixes #3634
Category:
Potential impacts: