Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use dep: and optional dependency feature ? syntax #1608

Merged
merged 4 commits into from
Mar 30, 2024
Merged

Use dep: and optional dependency feature ? syntax #1608

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6c7c709
refactor: use `dep:` prefix for `quote` dependency
BD103 Mar 30, 2024
694f604
feat: use optional dependency feature syntax `?`
BD103 Mar 30, 2024
4913ab2
chore: bump msrv to 1.60
BD103 Mar 30, 2024
d7650b2
chore: bump msrv to 1.60 (pt. 2)
BD103 Mar 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
33 changes: 16 additions & 17 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
strategy:
fail-fast: false
matrix:
rust: [stable, beta, 1.60.0, 1.56.0]
rust: [stable, beta, 1.60.0]
include:
- rust: nightly
components: rustc-dev
Expand All @@ -52,7 +52,6 @@ jobs:
os: windows
env:
target: ${{matrix.target && format('--target={0}', matrix.target)}}
manifestpath: ${{matrix.rust == '1.56.0' && '--manifest-path tests/crate/Cargo.toml' || ''}}
timeout-minutes: 45
steps:
- uses: actions/checkout@v4
Expand All @@ -61,21 +60,21 @@ jobs:
toolchain: ${{matrix.rust}}
targets: ${{matrix.target}}
components: ${{matrix.components}}
- run: cargo check ${{env.manifestpath}} ${{env.target}} --no-default-features
- run: cargo check ${{env.manifestpath}} ${{env.target}}
- run: cargo check ${{env.manifestpath}} ${{env.target}} --features full
- run: cargo check ${{env.manifestpath}} ${{env.target}} --features 'fold visit visit-mut'
- run: cargo check ${{env.manifestpath}} ${{env.target}} --features 'full fold visit visit-mut'
- run: cargo check ${{env.manifestpath}} ${{env.target}} --no-default-features --features derive
- run: cargo check ${{env.manifestpath}} ${{env.target}} --no-default-features --features 'derive parsing'
- run: cargo check ${{env.manifestpath}} ${{env.target}} --no-default-features --features 'derive printing'
- run: cargo check ${{env.manifestpath}} ${{env.target}} --no-default-features --features 'proc-macro parsing printing'
- run: cargo check ${{env.manifestpath}} ${{env.target}} --no-default-features --features full
- run: cargo check ${{env.manifestpath}} ${{env.target}} --no-default-features --features 'full parsing'
- run: cargo check ${{env.manifestpath}} ${{env.target}} --no-default-features --features 'full printing'
- run: cargo check ${{env.manifestpath}} ${{env.target}} --no-default-features --features 'full parsing printing'
- run: cargo check ${{env.manifestpath}} ${{env.target}} --no-default-features --features 'fold visit visit-mut parsing printing'
- run: cargo check ${{env.manifestpath}} ${{env.target}} --no-default-features --features 'full fold visit visit-mut parsing printing'
- run: cargo check ${{env.target}} --no-default-features
- run: cargo check ${{env.target}}
- run: cargo check ${{env.target}} --features full
- run: cargo check ${{env.target}} --features 'fold visit visit-mut'
- run: cargo check ${{env.target}} --features 'full fold visit visit-mut'
- run: cargo check ${{env.target}} --no-default-features --features derive
- run: cargo check ${{env.target}} --no-default-features --features 'derive parsing'
- run: cargo check ${{env.target}} --no-default-features --features 'derive printing'
- run: cargo check ${{env.target}} --no-default-features --features 'proc-macro parsing printing'
- run: cargo check ${{env.target}} --no-default-features --features full
- run: cargo check ${{env.target}} --no-default-features --features 'full parsing'
- run: cargo check ${{env.target}} --no-default-features --features 'full printing'
- run: cargo check ${{env.target}} --no-default-features --features 'full parsing printing'
- run: cargo check ${{env.target}} --no-default-features --features 'fold visit visit-mut parsing printing'
- run: cargo check ${{env.target}} --no-default-features --features 'full fold visit visit-mut parsing printing'
- if: matrix.components == 'rustc-dev'
run: cargo check --benches --all-features --release

Expand Down
6 changes: 3 additions & 3 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,20 +18,20 @@ include = [
keywords = ["macros", "syn"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/dtolnay/syn"
rust-version = "1.56"
rust-version = "1.60"

[features]
default = ["derive", "parsing", "printing", "clone-impls", "proc-macro"]
derive = []
full = []
parsing = []
printing = ["quote"]
printing = ["dep:quote"]
visit = []
visit-mut = []
fold = []
clone-impls = []
extra-traits = []
proc-macro = ["proc-macro2/proc-macro", "quote/proc-macro"]
proc-macro = ["proc-macro2/proc-macro", "quote?/proc-macro"]
test = ["syn-test-suite/all-features"]

[dependencies]
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ contains some APIs that may be useful more generally.
[`syn::DeriveInput`]: https://docs.rs/syn/2.0/syn/struct.DeriveInput.html
[parser functions]: https://docs.rs/syn/2.0/syn/parse/index.html

*Version requirement: Syn supports rustc 1.56 and up.*
*Version requirement: Syn supports rustc 1.60 and up.*

[*Release notes*](https://github.com/dtolnay/syn/releases)

Expand Down
26 changes: 0 additions & 26 deletions tests/crate/Cargo.toml
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion tests/crate/test.rs
View file
Open in desktop

This file was deleted.