Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for nulls last/first in order by #35

Merged
1 commit merged into from
Aug 22, 2023

Conversation

tvarsis
Copy link
Contributor

@tvarsis tvarsis commented Jul 17, 2023

This pull request solves so that it is possible to do null first/last in order by statements so they could look like these:

col1, col2 desc nulls last, col3 asc, col4 nulls first, col5 desc

This is and SQL standard and supported by both PotsgreSQL and OracleDB. MySQL and MS SQL have not yet implemented it, so if you try to append it on orders for those dbs, then it will return an error as expected, but should work fine if/when they do add support for it. Old kind of order by still works as expected even for those dbs.

I have tested and verify that this does not break existing functionality with order by asc/desc and have same "default to asc" behavior when no value is provided etc.

@tvarsis
Copy link
Contributor Author

tvarsis commented Jul 24, 2023

@wjgilmore @anas-srikou According to the readme in the main DF repo, it says that contributions are welcome. But I'm not sure if that is still accurate since it seems to pretty much never be any responses to issues/pull requests on the public repos. Do you guys still want community contributions going forward, if so, I would appreciate to know if this pull request be accepted or not? Thanks!

@ghost
Copy link

ghost commented Aug 4, 2023

Hi @tvarsis, sorry for the delay.
I will verify the changes as soon as possible and get back to you 🙏

@ghost ghost self-requested a review August 18, 2023 04:22
@ghost ghost merged commit d750cf5 into dreamfactorysoftware:master Aug 22, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant