fix(test): Execute SSUBSCRIBE command directly in client #4763
+4
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostasrim
reviewed
Mar 14, 2025
It could be that `pubsub.ssubscribe` function is async and doesn't wait for any response from server so execute command in client directly. Signed-off-by: mkaruza <mario@dragonflydb.io>
mkaruza
force-pushed
the
mkaruza/sleep-in-cluster-pubsub_shard_command-test
branch
from
67ae44c to
b929cb0
Compare
mkaruza
changed the title
kostasrim
approved these changes
Mar 14, 2025
| # We are executing SSUBSCRIBE commands and wait for them to be sure that | ||
| # channels are created | ||
| message = await c_nodes[0].execute_command("SSUBSCRIBE pubsub-shard-channel") | ||
| message = await c_nodes[0].execute_command("SSUBSCRIBE shard-channel") |
There was a problem hiding this comment.
When I get a chance I will check why consumer.ssubscribe is async (it might be a bug on redis-py worth reporting)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It could be that
pubsub.ssubscribefunction is async and doesn't waitfor any response from server so execute command in client directly