feat: allow non-ascii values in dfly_bench #4751
Merged
+65
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binary strings are supported by RESP protocol so we now generate commands using this protocol, so that we could pass binary strings. In addition, fixed "done" metric which did not account for number of shards cluster mode. Signed-off-by: Roman Gershman <roman@dragonflydb.io>
kostasrim
approved these changes
Mar 12, 2025
| if (!cmd_parts_.empty()) { | ||
| const string_view* cmd = get_if<string_view>(&cmd_parts_.front()); | ||
| if (cmd) { | ||
| might_hit_ = absl::EqualsIgnoreCase(*cmd, "get") || absl::StartsWithIgnoreCase(*cmd, "mget"); |
There was a problem hiding this comment.
Suggested change
| might_hit_ = absl::EqualsIgnoreCase(*cmd, "get") || absl::StartsWithIgnoreCase(*cmd, "mget"); | |
| might_hit_ = absl::EqualsIgnoreCase(*cmd, "get") || absl::EqualsIgnoreCase(*cmd, "mget"); |
| @@ -103,6 +102,11 @@ static string GetRandomHex(size_t len) { | |||
| } | |||
| } | |||
|
|
|||
| if (!ascii) { | |||
| for (size_t i = 0; i < len; i++) { | |||
| res[i] += 80; | |||
There was a problem hiding this comment.
hexadecimal characters with 0 padding start at ascii 0 which is 48. +80 moves the whole string to non-ascii range.
| }; | ||
|
|
||
| CommandGenerator::CommandGenerator(KeyGenerator* keygen) : keygen_(keygen) { | ||
| command_ = GetFlag(FLAGS_command); | ||
| value_ = string(GetFlag(FLAGS_d), 'a'); | ||
| is_ascii_ = GetFlag(FLAGS_ascii); | ||
| value_ = string(GetFlag(FLAGS_d), is_ascii_ ? 'a' : char(130)); |
| if (protocol == RESP) { | ||
| return absl::StrCat("set ", key, " ", value_, "\r\n"); | ||
| } | ||
| absl::StrAppend(&res, "*3\r\n$3\r\nset\r\n$", key.size(), "\r\n", key); |
There was a problem hiding this comment.
I blindly trust you with this 🤣
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
binary strings are supported by RESP protocol so we now generate commands using this protocol, so that we could pass binary strings.
In addition, fixed "done" metric which did not account for number of shards cluster mode.