chore: replace chrono with absl in PipelineCacheSizeTracker #4748
+5
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kostas <kostas@dragonflydb.io>
kostasrim
commented
Mar 11, 2025
| using Limits = std::numeric_limits<size_t>; | ||
|
|
||
| Tp last_check_ = Clock::now(); | ||
| absl::Time last_check_ = absl::Now(); |
There was a problem hiding this comment.
I am not convinced about any performance impacts of this (as promised I will benchmark / perf and see if chrono has any measurable overhead in our hot paths) but FOR SURE it has SHORTER naming and requires less typing 🤣
I promise once I get some free bandwidth I will make a case for this 😄 For now I am blindly trusting the sentiment.
adiholden
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use absl Time instead of Chrono in PipelineCacheSizeTracker