fix(server): hmget non uniqe keys response #4745
Merged
+11
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: adi_holden <adi@dragonflydb.io>
romange
reviewed
Mar 12, 2025
src/server/hset_family.cc
Outdated
| @@ -408,10 +408,14 @@ OpResult<vector<OptStr>> OpHMGet(const OpArgs& op_args, std::string_view key, Cm | |||
| if (pv.Encoding() == kEncodingListPack) { | |||
| uint8_t* lp = (uint8_t*)pv.RObjPtr(); | |||
|
|
|||
| absl::flat_hash_map<string_view, unsigned> reverse; | |||
| absl::flat_hash_map<string_view, std::vector<size_t>> reverse; | |||
There was a problem hiding this comment.
it's gonna be more cpu intensive because for 99.999% of the usecases vector is not needed.
Can you please use InlinedVector instead?
romange
reviewed
Mar 12, 2025
src/server/hset_family.cc
Outdated
| reverse.reserve(fields.size() + 1); | ||
| for (size_t i = 0; i < fields.size(); ++i) { | ||
| reverse.emplace(ArgS(fields, i), i); // map fields to their index. | ||
| auto [res_it, is_inserted] = |
There was a problem hiding this comment.
you can achieve the same with reverse[ArgS(fields, i)].push_back(i)
Signed-off-by: adi_holden <adi@dragonflydb.io>
romange
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4743