feat: allow cluster READONLY command #4727
Merged
+41
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BorysTheDev
force-pushed
the
allowClusterREADONLYcmd
branch
from
e2cf47e to
1aa3009
Compare
romange
reviewed
Mar 7, 2025
tests/dragonfly/cluster_test.py
Outdated
| assert await m1_node.client.execute_command("GET X") == "1" | ||
|
|
||
| # This behavior can be changed in the future | ||
| assert await m1_node.client.execute_command("GET Y") == None |
There was a problem hiding this comment.
yeah, just do not forget to actually call r1_node :)
romange
reviewed
Mar 7, 2025
| # create cluster master and replica | ||
| # For now replica always should work in read-only mode | ||
| # READONLY command returns always OK without any impact | ||
| # In the future we may decide to implement the same behavior as REDIS |
There was a problem hiding this comment.
please open an issue to actually implement this behavior. it can be minor for now.
romange
approved these changes
Mar 9, 2025
romange
pushed a commit
that referenced
this pull request
Mar 9, 2025
* feat: allow cluster READONLY command
adiholden
reviewed
Mar 9, 2025
| @@ -447,9 +447,6 @@ void ClusterFamily::Cluster(CmdArgList args, const CommandContext& cmd_cntx) { | |||
| } | |||
|
|
|||
| void ClusterFamily::ReadOnly(CmdArgList args, const CommandContext& cmd_cntx) { | |||
| if (!IsClusterEmulated()) { | |||
There was a problem hiding this comment.
use IsClusterEnabledOrEmulated here and in ClusterFamily::ReadWrite
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #4718