fix(dfly_bench): support dns resolution for cluster hosts #4715
+61
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e slot ranges. Initial parsing of MOVED response is done but slot migration is not supported yet. Signed-off-by: Roman Gershman <roman@dragonflydb.io>
romange
changed the title
BorysTheDev
reviewed
Mar 6, 2025
| @@ -104,9 +104,10 @@ static string GetRandomHex(size_t len) { | |||
| return res; | |||
| } | |||
|
|
|||
| using SlotRange = pair<uint16_t, uint16_t>; | |||
There was a problem hiding this comment.
maybe we can include cluster_defs.h ?
There was a problem hiding this comment.
i prefer to keep dfly_bench independent from the server.
BorysTheDev
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also support multiple slot ranges per node.
Initial parsing of MOVED response is done but slot migration is not supported yet.