refactor: clean cluster code #4707
Merged
+17
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostasrim
approved these changes
Mar 6, 2025
| cntx_.Reset(nullptr); | ||
| } | ||
| } | ||
|
|
||
| void SetLastError(dfly::GenericError err) ABSL_LOCKS_EXCLUDED(error_mu_) { | ||
| if (!err) |
There was a problem hiding this comment.
But if we call this then we have an error right ? Why would err be empty ?
There was a problem hiding this comment.
The error can be removed in another thread
| @@ -217,7 +217,7 @@ bool IncomingSlotMigration::Join(long attempt) { | |||
| void IncomingSlotMigration::Stop() { | |||
| string_view log_state = state_.load() == MigrationState::C_FINISHED ? "Finishing" : "Cancelling"; | |||
| LOG(INFO) << log_state << " incoming migration of slots " << slots_.ToString(); | |||
| cntx_.ReportCancelError(); | |||
| cntx_.Cancel(); | |||
There was a problem hiding this comment.
This is cancellation without submitting an error the the underline context right ?
There was a problem hiding this comment.
yes, just forgot to replace it previous time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just clean cluster code a little