fix: SendInvalidationTrackingMessage should not block. #4680
+77
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romange
force-pushed
the
DbSlice
branch
3 times, most recently
from
11c38df to
d3a7caf
Compare
|
do we have some open github issue related to this fix? |
adiholden
previously approved these changes
Mar 3, 2025
|
@adiholden no, I just saw it while reading the db_slice code. |
We call PerformDeletion in an atomic block, which in turn calls SendInvalidationTrackingMessage that could block. We fix it by separating the blocking logic by moving the invalidation messages into a designated send queue and flush it later. In addition rename the function to make it explicit that they are atomic (i.e. not blocking). Signed-off-by: Roman Gershman <roman@dragonflydb.io>
adiholden
approved these changes
Mar 3, 2025
Good catch, I made changes around this code through time but I didn't notice it :) No worries for the pub/sub. On this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We call PerformDeletion in an atomic block, which in turn calls SendInvalidationTrackingMessage that could block. We fix it by separating the blocking logic by moving the invalidation messages into a designated send queue and flush it later.
In addition rename the function to make it explicit that they are atomic (i.e. not blocking).