feat: Added a flag to ignore key expiry. #4667
Merged
+35
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
H4R5H1T-007
changed the title
BorysTheDev
reviewed
Feb 27, 2025
romange
reviewed
Feb 28, 2025
src/server/rdb_test.cc
Outdated
| EXPECT_EQ(ttl2, -1); | ||
|
|
||
| // reverting back the changes before next text case run | ||
| SetTestFlag("ignore_expiry", "false"); |
There was a problem hiding this comment.
please use absl::FlagSaver fs; for that - see in other tests
|
I have cached the flag into rdb loader object and I have also used flagsaver as mentioned. Is this fine now or do I need to modify anything else? |
romange
reviewed
Mar 2, 2025
Added a new flag --rdb_ignore_expiry to ignore key expiry when loading from RDB Snapshot. Also cached this flag into RDBLoader object to reuse it.
|
LGTM |
romange
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3858.
Added a new flag
--ignore-expiryto ignore key expiry when loading from rdb snapshot.