chore: snapshot/tiering improvements #4661
Merged
+62
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romange
force-pushed
the
TieredImprov
branch
from
496256e to
858b042
Compare
romange
commented
Feb 25, 2025
| @@ -89,6 +89,20 @@ class SliceSnapshot { | |||
| snapshot_fb_.JoinIfNeeded(); | |||
| } | |||
|
|
|||
| uint64_t snapshot_version() const { | |||
There was a problem hiding this comment.
just moved here, no changes
romange
commented
Feb 25, 2025
| {db_indx, PrimeKey(pk.ToString()), std::move(future), expire_time, mc_flags}); | ||
| ++type_freq_map_[RDB_TYPE_STRING]; | ||
| // TODO: we loose the stickiness attribute bly cloning like this PrimeKey. | ||
| SerializeExternal(db_indx, PrimeKey{pk.ToString()}, pv, expire_time, mc_flags); |
There was a problem hiding this comment.
code moved into SerializeExternal
kostasrim
reviewed
Feb 25, 2025
kostasrim
reviewed
Feb 25, 2025
kostasrim
reviewed
Feb 25, 2025
romange
force-pushed
the
TieredImprov
branch
from
27cd7f9 to
fe1b005
Compare
romange
commented
Feb 25, 2025
| PrimeValue pv{entry.value.Get()}; // Might block until the future resolves. | ||
|
|
||
| // TODO: to introduce RdbSerializer::SaveString that can accept a string value directly. | ||
| serializer_->SaveEntry(entry.key, pv, entry.expire, entry.mc_flags, entry.dbid); |
There was a problem hiding this comment.
we had a bug with reversed mc_flags and dbid that is fixed here.
romange
force-pushed
the
TieredImprov
branch
4 times, most recently
from
d20f06f to
15558f3
Compare
Mainly comments and refactorings. There are two functional differrences: 1. flush serialized entries in case we gathered at least K delayed entries coming from tiered entities. 2. allow loading snapshots larger than memory for tiered enabled datastores. Co-authored-by: Kostas Kyrimis <kostas@dragonflydb.io> Signed-off-by: Roman Gershman <roman@dragonflydb.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly comments and refactorings.
There are two functional differrences:
entries coming from tiered entities.
Also pull latest helio with some bug fixes in gcs code.
Signed-off-by: Roman Gershman roman@dragonflydb.io