feat: implement unique keys counting using hll #4652
Merged
+98
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romange
commented
Feb 24, 2025
| @@ -1301,9 +1301,10 @@ int convertSparseToDenseHll(struct HllBufferPtr in_hll, struct HllBufferPtr out_ | |||
| return C_OK; | |||
| } | |||
|
|
|||
| int pfadd_sparse(sds* hll_ptr, unsigned char* value, size_t size, int* promoted) { | |||
| int pfadd_sparse(sds* hll_ptr, const unsigned char* value, | |||
There was a problem hiding this comment.
changed the interface to accept const unsigned char. unfortunately the internal utilities still require a mutable buffer, so I remove const below.
HyperLogLog is an efficient data structure for approximate counting of unique elements. We use it to sample the traffic via "DEBUG KEYS ON/OFF" command. Signed-off-by: Roman Gershman <roman@dragonflydb.io>
BorysTheDev
reviewed
Feb 24, 2025
| struct hllhdr* hdr = (struct hllhdr*)(*hll_ptr); | ||
| int retval = hllSparseAdd(hll_ptr, value, size, promoted); | ||
| int retval = hllSparseAdd(hll_ptr, (unsigned char*)value, size, promoted); |
BorysTheDev
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HyperLogLog is an efficient data structure for approximate counting of unique elements. We use it to sample the traffic via "DEBUG KEYS ON/OFF" command.