CI: add slow regression tests #4646
Merged
+6
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romange
reviewed
Feb 23, 2025
.github/workflows/ci.yml
Outdated
| @@ -210,7 +210,7 @@ jobs: | |||
| dfly-executable: dragonfly | |||
| run-only-on-ubuntu-latest: true | |||
| build-folder-name: build | |||
| filter: ${{ matrix.build-type == 'Release' && '(not slow) and (not dbg_only)' || '(not slow) and (not opt_only)' }} | |||
| filter: ${{ matrix.build-type == 'Release' && '(not dbg_only)' || '(not slow) and (not opt_only)' }} | |||
There was a problem hiding this comment.
dbg_only is not present anywhere in pytests. is it ok?
also maybe add a comment explaining that for non-release builds we run only non slow and not opt_only tests
There was a problem hiding this comment.
looks like dbg_only was only for one test in the past and this marker was removed
I will add the comment
romange
previously approved these changes
Feb 23, 2025
romange
previously approved these changes
Feb 23, 2025
romange
reviewed
Feb 23, 2025
.github/workflows/ci.yml
Outdated
| @@ -210,7 +210,8 @@ jobs: | |||
| dfly-executable: dragonfly | |||
| run-only-on-ubuntu-latest: true | |||
| build-folder-name: build | |||
| filter: ${{ matrix.build-type == 'Release' && '(not slow) and (not dbg_only)' || '(not slow) and (not opt_only)' }} | |||
| # None release build will not run tests marked as slow or opt_only | |||
There was a problem hiding this comment.
Suggested change
| # None release build will not run tests marked as slow or opt_only | |
| # Non-release build will not run tests marked as slow or opt_only |
adiholden
commented
Feb 23, 2025
| @@ -210,7 +210,8 @@ jobs: | |||
| dfly-executable: dragonfly | |||
| run-only-on-ubuntu-latest: true | |||
| build-folder-name: build | |||
| filter: ${{ matrix.build-type == 'Release' && '(not slow) and (not dbg_only)' || '(not slow) and (not opt_only)' }} | |||
| # Non-release build will not run tests marked as slow or opt_only | |||
| filter: ${{ matrix.build-type == 'Release' && 'not empty' || '(not slow) and (not opt_only)' }} | |||
There was a problem hiding this comment.
not empty is needed because we can not use empty filter
There was a problem hiding this comment.
of course we dont have any empty marker in our code
There was a problem hiding this comment.
I would consider leaving a comment for this -- we will forget it in one week from now 🤣
|
Currenly our regression tests fail. I will be able to merge this PR only after rebase of code fix |
kostasrim
previously approved these changes
Feb 24, 2025
adiholden
force-pushed
the
ci_add_slow_regression_tests
branch
from
da03c17 to
c6337f5
Compare
Signed-off-by: adi_holden <adi@dragonflydb.io>
Signed-off-by: adi_holden <adi@dragonflydb.io>
Signed-off-by: adi_holden <adi@dragonflydb.io>
Signed-off-by: adi_holden <adi@dragonflydb.io>
adiholden
force-pushed
the
ci_add_slow_regression_tests
branch
from
1be1cda to
9520839
Compare
Signed-off-by: adi_holden <adi@dragonflydb.io>
kostasrim
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.