chore: get rid of lispack stats #4644
Merged
+37
−81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romange
commented
Feb 22, 2025
| @@ -51,6 +51,30 @@ bool StringSet::Add(string_view src, uint32_t ttl_sec) { | |||
| return true; | |||
| } | |||
|
|
|||
| unsigned StringSet::AddMany(absl::Span<std::string_view> span, uint32_t ttl_sec) { | |||
There was a problem hiding this comment.
moved from the header file
romange
commented
Feb 22, 2025
| @@ -29,7 +29,7 @@ class StringSet : public DenseSet { | |||
| // Returns true if elem was added. | |||
| bool Add(std::string_view s1, uint32_t ttl_sec = UINT32_MAX); | |||
|
|
|||
| template <typename T> unsigned AddMany(absl::Span<T> span, uint32_t ttl_sec); | |||
| unsigned AddMany(absl::Span<std::string_view> span, uint32_t ttl_sec); | |||
romange
commented
Feb 22, 2025
| RETURN_ON_ERR(LoadKeyValPair(type, &settings)); | ||
| int delta_ms = (absl::GetCurrentTimeNanos() - start) / 1000'000; |
There was a problem hiding this comment.
moved inside LoadKeyValPair function
They were wrong, we usually do not need them, and they complicated code. The right way to do it - to add them to OBJHIST statistics. In addition, did some other code improvements without functional changes. Signed-off-by: Roman Gershman <roman@dragonflydb.io>
romange
requested review from
adiholden
and removed request for
BorysTheDev and
kostasrim
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They were wrong, we usually do not need them,
and they complicated code. The right way to do it - to add them to OBJHIST statistics.
In addition, did some other code improvements without functional changes.